Enchantments are saved as shorts, but are loaded as and function with integer values

Okay, the code that is responsible for adding an enchantment is very weird.
This code is from 1.12 using mcp 940

net.minecraft.item.ItemStack.addEnchantment(Enchantment, int)

/**
 * Adds an enchantment with a desired level on the ItemStack.
 */
public void addEnchantment(Enchantment ench, int level)
{
	if (this.stackTagCompound == null)
	{
		this.setTagCompound(new NBTTagCompound());
	}
	
	if (!this.stackTagCompound.hasKey("ench", 9))
	{
		this.stackTagCompound.setTag("ench", new NBTTagList());
	}
	
	NBTTagList nbttaglist = this.stackTagCompound.getTagList("ench", 10);
	NBTTagCompound nbttagcompound = new NBTTagCompound();
	nbttagcompound.setShort("id", (short)Enchantment.getEnchantmentID(ench));
	nbttagcompound.setShort("lvl", (short)((byte)level));
	nbttaglist.appendTag(nbttagcompound);
}

The method accepts an int as parameter, then when adding it casts it to a byte, and then stores it as a short. Only thing that's missing here is a long.

Edit
The code in 1.13-pre1 looks very similar. This code was decompiled using the CFR decompiler.

awr.a(azq, int)

public void a(azq azq2, int n2) {
	this.o();
	if (!this.g.c("Enchantments", 9)) {
		this.g.a("Enchantments", new hd());
	}
	hd hd2 = this.g.d("Enchantments", 10);
	gx gx2 = new gx();
	gx2.a("id", String.valueOf(azq.b.b(azq2)));
	gx2.a("lvl", (short)((byte)n2));
	hd2.a(gx2);
}

the o() method seems to initialize the stackTagCompound field (g) if it is null. That's what has been there before, just in its own method. Other than that, there where some changes to the tag itself: It was renamed to Enchantments and is now using a String-ID.

@@unknown, it looks like this method is (at least in 1.12.2) only used for cases where the level is restricted to maximum values of the enchantments anyways (enchantment table, loot tables, /enchant ...), so it is not such a big problem.

Still in 18w50a.

Tested in 20w07a, stick stays at level 32768 even after relogging.

Why was this marked as affecting 20w07a?

That's the same behavior as before

Where's the issue then? How am I supposed to reproduce it?

1. /give @p diamond_sword
2. /enchant @p sharpness
3. /data get entity @p SelectedItem.tag.Enchantments[0].lvl
→ 1s instead of 1

Can reproduce that.

Makes me believe I may have also come to the wrong conclusions for the related ticket MC-135506, can you check that one?

Can confirm in 21w03a.

So is it means that 32767 will no longer happens?