mojira.dev
MC-134498

Client getting disconnected from server does not log message (nor exception)

The bug

When the client gets disconnected from a server (for example because it was kicked, timed out or an exception occurred) the message is not logged and additionally for exceptions the stacktrace is not logged either.

NetworkManager.exceptionCaught(ChannelHandlerContext, Throwable) logs exceptions only with the logging level DEBUG, which makes sense for the server, but not for the client.

Expected behavior:

  • "Regular" disconnects (kicked, timeout?): Message is logged as "Info"

  • "Unexpected" disconnects: Message is logged as "Error" including exception stacktrace


Note that the logged message for a packet error (at DEBUG level) also has a typo ("Failed to sent packet") and is used even for receiving an invalid packet, not just sending.

Linked issues

Comments 2

Note that the logged message for a packet error (at DEBUG level) also has a typo ("Failed to sent packet") and is used even for receiving an invalid packet, not just sending.

Can confirm in 23w03a

marcono1234

(Unassigned)

Confirmed

Networking

disconnect, logging

Minecraft 1.13, Minecraft 18w30a, Minecraft 18w30b, Minecraft 18w31a, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 18w50a, 1.16.5, 21w11a, 23w03a

Retrieved