Structure advancements

Please attach the data pack here.

@Neko That should be done now. You Should have the relevant part of the datapack.

What's happening is that you forgot to capitalize the words in the location names (i.e. Ocean_Ruin, Buried_Treasure, Shipwreck, etc.)

{{ "display": { "icon": { "item": "minecraft:filled_map" }, "title": "Hidden Booty", "description": "Use a treasure map to find buried treasure" }, "parent": "custom:ocean/shipwreck", "criteria": { "buried_treasure": { "trigger": "minecraft:location", "conditions": { "feature": "[buried_treasure]" } } }}

{{ "display": { "icon": { "item": "minecraft:spruce_boat" }, "title": "Going Down", "description": "Enter a shipwreck" }, "parent": "custom:ocean/root", "criteria": { "shipwreck": { "trigger": "minecraft:location", "conditions": { "feature": "[shipwreck]" } } }}

{{ "display": { "icon": { "item": "minecraft:polished_granite" }, "title": "Bits of Atlantis", "description": "Find some oceanic ruins" }, "parent": "custom:ocean/root", "criteria": { "ocean_ruin": { "trigger": "minecraft:location", "conditions": { "feature": "[ocean_ruin]" } } }}

I've marked the mistakes with square brackets, because for some reason you can't use bold, italic, etc. in a code bracket.

I've just edited the code in the advancements and now it just automatically gives itself to the player. I think this means the structure name is invalid. When is wasn't capitalised it didn't automatically give itself to you which I take to mean the structure name is valid.

I'm using this datapack in the 19w07a snapshot. Are you? Maybe it changed in the snapshot?

I'm honestly not familiar with making advancements, so I've been looking at the Minecraft wiki. It says that the valid inputs for "feature" in the conditions for "minecraft:location" are the same as for the /locate command.

I did try that first but it didn't work. When I tried removing the capitals however, it worked for all the structures except the ocean ruins, shipwreck and buried treasure. I think maybe Mojang did something different when implementing structures in 1.13.

This is caused by MC-129491.