[MC-164847] Riptide spinning animation not showing when using riptide after just coming out of water

The bug

The riptide spinning animation not showing when using riptide after just coming out of water. You will just get launched and the animation isn't showing and the sound isn't playing.

Example

Here is an example in video:

[media]

Linked issues

is duplicated by

MC-128599 Throwing a riptide enchanted trident with the slow falling effect while swimming up does not always play the trident launching animation.

relates to

MC-224949 Blocks placed next to bounding box when slowly moving are getting canceled

MC-128007 Player stuck in the sky after using riptide enchantment

Attachments

2023-11-10_22-18-03.mp4

First person pov.mp4

MC-164847.mp4

Riptide spinning animation not showing when using riptide after just coming out of water.mp4

Second person pov.mp4

Comments

bugsbugsbugs 2020-06-18T14:56:12Z

Affects 1.16-rc1

bugsbugsbugs 2020-06-18T14:56:36Z

May be easier to reproduce when having slow falling.

Hunter M 2021-08-13T15:35:51Z

This bug seems to occur because the client and server disagree on the client's position, because of this line in ClientPlayerEntity:

boolean flag1 = d4 * d4 + d0 * d0 + d1 * d1 > 9.0E-4D || this.positionReminder >= 20;

This stops the client sending small movements under 0.03 blocks to the server. The easiest fix would be changing that line to this line:

boolean flag1 = d4 * d4 + d0 * d0 + d1 * d1 > 0 || this.positionReminder >= 20;

This would send all movements to the server and would prevent this desync.

Affects 1.17.1

[Mod] Jingy 2023-11-11T04:18:41Z

Can confirm in the latest version. 1.20.2 and 23w45a:

[media]