Drinking honey bottles increases "minecraft.used:minecraft.honey_bottle" by a value of two and runs the "minecraft:consume_item" advancement trigger twice

Can confirm in 20w46a.

Can confirm in 21w03a.

Can confirm in 21w08b. Video attached.

Can confirm in 21w15a.

Can confirm in 21w16a. I'd like to request ownership of this ticket since the current reporter has been inactive since July 2020. I'm willing to provide all of the necessary information and will keep this report updated.

Code analysis (Yarn mappings)

Honey bottles are a custom item with a food component. The HoneyBottleItem class triggers the criterion in its implementation of the Item#finishUsing method:

@Override
public ItemStack finishUsing(ItemStack stack, World world, LivingEntity user) {
	super.finishUsing(stack, world, user);
	if (user instanceof ServerPlayerEntity serverUser) {
		Criteria.CONSUME_ITEM.trigger(serverUser, stack); // custom item trigger
		serverUser.incrementStat(Stats.USED.getOrCreateStat(this));
	}
}

However, the base implementation of the Item#finishUsing method already triggers the criterion for foods through the player's implementation of the LivingEntity#eatFood method:

@Override
public ItemStack eatFood(World world, ItemStack stack) {
	this.getHungerManager().eat(stack.getItem(), stack);
	this.incrementStat(Stats.USED.getOrCreateStat(stack.getItem()));
	world.playSound(null, this.getX(), this.getY(), this.getZ(), SoundEvents.ENTITY_PLAYER_BURP, SoundCategory.PLAYERS, 0.5f, world.random.nextFloat() * 0.1f + 0.9f);

	if (this instanceof ServerPlayerEntity serverPlayer) {
		Criteria.CONSUME_ITEM.trigger(serverPlayer, stack); // food trigger
	}

	return super.eatFood(world, stack);
}

One recommended fix is to simply remove the unnecessary criterion trigger from the HoneyBottleItem class.

This issue still exists in Minecraft 1.19.4 release candidate 3.

This issue still exists in 1.20.4.

This issue was present in 24w33a but no longer occurs in 24w34a. This issue was fixed in 24w34a.