[MC-197267] Guardians fail to make flopping sounds if they aren't centered on a solid block

If a guardian doesn't land centered on a solid block, it won't make a flopping noise. This most often happens when an elder guardian flops on a hill, or when guardians flop on top of stacked carpets.

Related issues

relates to

MC-1133 Whether or not a player experiences some effect is calculated based on the block under the center of the player

Attachments

MC-197267.mp4

Screen Shot 2020-08-06 at 3.37.03 PM.png

Screen Shot 2020-08-06 at 3.37.22 PM.png

Comments

migrated 2020-08-06T19:41:04Z

[media][media][media]

[Mod] markderickson 2020-08-06T22:09:13Z

Hi there!

I can confirm for 1.16.2pr3.

Avoma 2021-01-15T15:12:35Z

Can confirm in 20w51a.

Avoma 2021-01-25T19:25:44Z

Can confirm in 21w03a.

Avoma 2021-02-14T11:46:00Z

Can confirm in 21w06a.

Avoma 2021-02-21T15:39:15Z

Can confirm in 21w07a.

Avoma 2021-02-27T18:44:31Z

Can confirm in 21w08b. Video attached.

Avoma 2021-03-24T15:12:24Z

Can confirm in 21w11a.

Avoma 2021-04-13T16:21:47Z

Can confirm in 21w14a.

Avoma 2021-06-11T18:01:17Z

Can confirm in 1.17.

Avoma 2021-07-14T17:22:55Z

Can confirm in 1.17.1.

Avoma 2021-12-24T16:01:49Z

Can confirm in 1.18.1.

Avoma 2022-01-12T15:17:18Z

Here's a code analysis of this issue. The following is based on a decompiled version of Minecraft 1.18.1 using MCP-Reborn.

Code Analysis:

net.minecraft.world.entity.monster.Guardian.java

public class Guardian extends Monster {
   ...
   public void aiStep() {
      if (this.isAlive()) {
         if (this.level.isClientSide) {
            this.clientSideTailAnimationO = this.clientSideTailAnimation;
            if (!this.isInWater()) {
               this.clientSideTailAnimationSpeed = 2.0F;
               Vec3 vec3 = this.getDeltaMovement();
               if (vec3.y > 0.0D && this.clientSideTouchedGround && !this.isSilent()) {
                  this.level.playLocalSound(this.getX(), this.getY(), this.getZ(), this.getFlopSound(), this.getSoundSource(), 1.0F, 1.0F, false);
               }

               this.clientSideTouchedGround = vec3.y < 0.0D && this.level.loadedAndEntityCanStandOn(this.blockPosition().below(), this);
            } ...

This issue stems from the above class. I'm not exactly sure what's causing it but I'm confident in saying that the problem exists within this particular piece of code.

Avoma 2022-03-30T11:13:45Z

Can confirm in 1.18.2 and 22w12a.

Avoma 2022-07-04T19:15:35Z

Can confirm in 1.19.

Avoma 2022-10-15T18:32:57Z

Can confirm in 1.19.2.