The bug
Item frames (including glow item frames) are an entity. However, despite this, their assets exist under the "blocks" directories.
How to reproduce
Check the block assets folders in the minecraft jar file
Expected results
The item frame resources would not be there.
Actual results
They are.
How to fix
Move these accordingly:
Old location | New location |
|---|---|
textures/block/glow_item_frame.png | textures/entity/glow_item_frame.png |
textures/block/item_frame.png | textures/entity/item_frame.png |
models/block/glow_item_frame.png | models/entity/glow_item_frame.png |
models/block/glow_item_frame_map.png | models/entity/glow_item_frame_map.png |
models/block/item_frame.png | models/entity/item_frame.png |
models/block/item_frame_map.png | models/entity/item_frame_map.png |
models/block/template_item_frame.png | models/entity/template_item_frame.png |
models/block/template_item_frame_map.png | models/entity/template_item_frame_map.png |
Further notes
On a related note, since they do use states like a block does, it may be worth changing the blockstates/ directory to states/block, and also having a states/entity directory, which item frames' definitions could be moved to.
Old location | New location |
|---|---|
blockstates/glow_item_frame.png | states/entity/glow_item_frame.png |
blockstates/item_frame.png | states/entity/item_frame.png |
blockstates/* | states/block/* |
items/* | states/item/* |
Linked issues
relates to 12
MC-212653
Several item models exist in the models/block folder, despite not being block models
Resolved
MC-212740
Textures for empty slots are in the textures/item folder, despite not being actual items
Resolved
MC-200944
Block cracking textures are in the block textures folder, despite not being block textures
Open
MC-212656
Lava and water textures/models are in the blocks folder, despite not being blocks
Open
MC-271366
Banner textures are not located in an optimal or intuative file path for resource pack creators
Resolved
Hi! I can confirm.