mojira.dev
MC-203712

Amethyst Geodes cause floating water/lava to generate when intersecting water/lava caves/pools

The generation of Amethyst Geodes seems to halt the flowing and updating of liquids, resulting in liquids such as the lava attached halting in midair. It occurs with both lava and water, but can be odd in some instances, as in some cases liquids seem to behave naturally while in others only certain regions of generation seem to mess with it. If i had to guess, it has something to do with the external region of the generation on the Geodes with opened sides, as this is where problems seem to most often occur. If I had to guess, it would probably be a few air blocks placed in the "open end" of the geode's structure file, causing the water/lava stream to be "cut off" and hang in the air.

Example location (from MC-204085)

Seed: 505307592494160803
Location: -453 10 -487

Linked issues

MC-203654 Water source blocks stay in place even if an amethyst geode generates under it Resolved MC-203885 Lava floating near amethyst geode in new snapshot Resolved MC-203890 Amethyst geodes that generate in ocean biomes are not filled with water. Resolved MC-203932 Generation bug when Geode spawns near ocean Resolved MC-204051 floating lava amethyst geodes Resolved

Attachments

Comments 9

Duplicate of (modified) MC-32813

Reopened, geodes aren't part of the regular cave carver as far as I can tell.

Hello, I've written code to fix this bug and have attached it below. The way I've solved this is to check for water when generating the geode, and flooding it (replacing the air with water) if it's touching water, as it's more than likely the geode is in the ocean or touching a flooded cave. For lava, if the geode finds lava when generating, the geode will fill until the max lava level. To handle this, the new code stores the air positions in a list and defers placement until the geode is fully generated.

 

Here's the code, in official mappings. The parts I've changed have a "// change:" comment before them.

https://gist.github.com/SuperCoder7979/c06a216ab635790832db954f9754a3aa

Licensed under CC0.

 

Here's a screenshot taken with the seed -3902724624318935087 at 312 54 323, with the code working:

[media]

As you can see, the geode generates flooded 🙂

Confirmed for 20w46a.

Added more images

Can confirm in 21w03a.

Can confirm in 21w05b.

Can confirm in 21w13a.

Can confirm in 21w17a.

ape enthusiast

coschevi

Confirmed

Important

World generation

20w45a, 20w46a, 20w48a, 20w49a, 20w51a, ..., 21w10a, 21w11a, 21w13a, 21w16a, 21w17a

21w20a

Retrieved