[MC-2188] Item gets used when right clicking on a saddled pig

When hold an item such as a splash potion or ender pearl, right clicking on a pig will use that item and make you get on the pig. Same thing for getting off.

Code analysis: https://bugs.mojang.com/browse/MC-2188?focusedCommentId=303628&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-303628

Linked issues

is duplicated by 2

MC-11695 Right-Click actions are still performed when mounting saddled pigs Resolved

MC-69597 When riding pig, right-click action is done Resolved

relates to 3

MC-106302 Unable to name saddled pigs Resolved

MC-19033 Pig with a saddle loses name and you get the name tag back when chunk the pig is in gets unloaded Resolved

MC-14525 name tag item doesn't work on entities with right click ability Resolved

Comments 21

Tails 2012-11-25T18:57:43Z

Confirmed in 1.4.5.

Hartspoon 2014-03-03T16:11:15Z

Still a concern in 14w08a.

marcono1234 2014-05-23T16:44:04Z

Confirmed for 14w21b

S P 2014-08-24T12:50:11Z

Confirmed in 1.8-pre1

uzon 2015-08-07T10:55:45Z

Confirmed in 15w32b.

11 more comments

marcono1234 2015-10-16T12:43:06Z

Confirmed for

15w42a

James (inactive) 2016-01-03T20:50:06Z

Confirmed for 15w51b.

I've tested this with water/lava buckets, snowballs/eggs/ender pearls, and all boats.

James (inactive) 2016-01-13T23:17:41Z

Confirmed for 16w02a.

James (inactive) 2016-03-15T23:35:19Z

Confirmed for 1.9.1-pre3.

null 2016-05-06T00:05:36Z

Confirmed for 1.9.3-pre3.

marcono1234 2016-05-08T20:39:08Z

Please link to this comment in the description

The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.

The reason for this is that the method net.minecraft.entity.passive.EntityPig.func_184645_a(EntityPlayer, EnumHand, ItemStack) always returns for the client that it did not successfully interacted with the pig. Instead it should return that it successfully interacted with the pig but only start riding the pig server-side.

public boolean func_184645_a(EntityPlayer p_184645_1_, EnumHand p_184645_2_, ItemStack p_184645_3_)
{
    if (!super.func_184645_a(p_184645_1_, p_184645_2_, p_184645_3_))
    {
        // Replaced this
        //if (this.getSaddled() && !this.worldObj.isRemote && !this.isBeingRidden())
        //    {
        //        p_184645_1_.startRiding(this);
        //        return true;
        //    }
        if (this.getSaddled() && !this.isBeingRidden())
        {
            if (!this.worldObj.isRemote) {
                p_184645_1_.startRiding(this);
            }
            
            return true;
        }
        else
        {
            return false;
        }
    }
    else
    {
        return true;
    }
}