Item gets used when right clicking on a saddled pig

Confirmed for

• 15w42a

Confirmed for 15w51b.

I've tested this with water/lava buckets, snowballs/eggs/ender pearls, and all boats.

Confirmed for 16w02a.

Confirmed for 1.9.1-pre3.

Confirmed for 1.9.3-pre3.

Please link to this comment in the description

The following is based on a decompiled version of Minecraft 1.9 using MCP 9.24 beta.

The reason for this is that the method net.minecraft.entity.passive.EntityPig.func_184645_a(EntityPlayer, EnumHand, ItemStack) always returns for the client that it did not successfully interacted with the pig. Instead it should return that it successfully interacted with the pig but only start riding the pig server-side.

public boolean func_184645_a(EntityPlayer p_184645_1_, EnumHand p_184645_2_, ItemStack p_184645_3_)
{
    if (!super.func_184645_a(p_184645_1_, p_184645_2_, p_184645_3_))
    {
        // Replaced this
        //if (this.getSaddled() && !this.worldObj.isRemote && !this.isBeingRidden())
        //    {
        //        p_184645_1_.startRiding(this);
        //        return true;
        //    }
        if (this.getSaddled() && !this.isBeingRidden())
        {
            if (!this.worldObj.isRemote) {
                p_184645_1_.startRiding(this);
            }
            
            return true;
        }
        else
        {
            return false;
        }
    }
    else
    {
        return true;
    }
}

Confirmed for 1.9.4.

Confirmed for 16w20a.

Confirmed for 16w21a.

Confirmed for 16w21b.

Confirmed for 1.10-pre1.