mojira.dev
MC-225367

Magma Cube's layers UV mapping overlaps

Segments 1, 2, 5, 6, 7, and 8 of a magma cube overlap with each other, causing problems when modifying the texture in a resource pack.

Steps to Reproduce:

  1. Download and apply the provided resource pack:

[media]
  1. Summon/spawn a magma cube

  2. Wait for it to jump, and spread out its model

  3. (optional) freeze the game

    /tick freeze

Observed Behavior:

The top and bottom faces of the previously listed model segments will be textured incorrectly, including the front and left sides of the previous segments before it in the texture.

Expected Result:

Each model segment could be modified separately from one another, without any overlap.

Screenshots/Videos:

[media]

Notes:

Related to MC-256371 MC-271509

Old Description:

The description has been modified, because the previous one was fairly messy and over descriptive. I have left the old description in a pinned comment here:

https://bugs.mojang.com/browse/MC-225367?focusedId=1337489&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1337489

Linked issues

Attachments

Comments

InfinitySwordofDiamond

Try removing all your existing resourcepacks.  Does that solve the issue?

Vulcan Fire

It does not. When finding and testing this issue I only had the one resource pack enabled.

anthony cicinelli

Please provide the resource pack along with a screenshot with your debug screen enabled (F3)

Vulcan Fire

Alright. I have provided the material that you asked for.

anthony cicinelli

Thank you for your report!
However, this issue is Invalid.

Your game, launcher or server is modified.
If you can reproduce the issue in a vanilla environment, please recreate the issue.

  • Any non-standard client/server/launcher build needs to be taken up with the appropriate team, not Mojang.

  • Any plugin issues need to be addressed to the creator of the plugin or resource pack.

  • If you have problems on large servers, such as The Hive and Hypixel, please contact them first as they run modified server software.

Quick Links:
📓 Bug Tracker Guidelines – 💬 Community Support – 📧 Mojang Support
📓 Project Summary – ✍️ Feedback and Suggestions – 📖 Game Wiki

Vulcan Fire

Alright. I updated the screenshots with ones of me using the current release of the game and the issue persists.

[Mod] Jingy

This is functioning as intended.

If you look here at this screenshot of the magma cube model being opened in block bench, you can see that this is how each cube behaves when picking what to put down as the texture.

[media]

As for your resource pack, the top and bottom of each cube section is being rendered fine and as intended.

[media]

As for the colored one, it was broken because you were missing a bottom section for the texture, but other than that it's working as intended (as shown below)

[media]

Basically this is an issue with the resource pack, not the texture UV.

user-f2760

Requesting reopen, this is very much an issue in vanilla, and prevents giving the magma cube a bottom texture that is not used on the sides; the texture map for each of the layers has the top/bottom overlapping the front/right faces, with the exception of the eye layers.

As for the above comment:
This is an actual obstacle to resource packs that they cannot fix.
Overlapping UV mappings have been considered valid bugs in the past and should be deemed as such. Unless you have an actual source from Mojang saying it is intended, this won't be resolved as such. Current behavior cannot be used as source, as then every report would be WAI'd.

This can only be resolved in 1 way: increase texture file size, and move every layer off to it's own area, like the eye layers. Otherwise there will always be overlapping UV areas.

If needed, I'm willing to keep this report updated.

[Mod] markderickson

I've changed the reporter of this issue to @unknown due to the level of detail provided in the comment above and the original reporter's inactivity on this ticket. If you'd like ownership returned, @unknown, please leave a comment here. 🙂

Vulcan Fire

Very sorry for my lack of activity. I’ve been busy with school and other life stuff that I haven’t been able to respond. I’ve been receiving the updates that Dhranios has given in my email. Glad he noticed the issue as well so this can be resolved. I will be out for most of today but if you guys need anything from me I can provide it for you later today.

Lyle Alexander Artain

Here you can see the texture mapping showing the pieces of the model, but instead of having 8 top and bottom cubes for all the inside layers and the bottom like how it's shown with the patty and tomato in the bottom right of the texture .png the texture mapping is set to overlap the top and bottom image of the top and bottom of the whole mob, resulting in an overlapping texture on the inside for a majority of layers (tomato and patty excluded because they happen to have their own top/bottom section in the bottom right)

 

I'm unsure if the mapping defaulted to this setup to fill each part of the model because it didn't have all the sides it needed available, or if the overlay is manually made to fit the image and paired with the model through coding. The texture file itself doesn't need to increase in size, I took the original, moved things and duplicated the current tomato and patty cubes to make the amount needed to fill the whole model. The blank space in mine being where the inner cube texture would go. The file itself is a perfect size, nothing has to be rescaled or resized. 

 

In vanilla the magma cube is majority of one color and texture, a texture that when overlapped can look fine, but if it were changed ever, it would be very noticable. This issue especially impacts the community members who make resource packs and texture packs because they can't utilize the unique layers or this mob without it ending up looking, like a mess. 

 

I'm all for limiting things to spark creativity, but this should not be something that contributes to the limitations.

Now with 1.20 coming up, and the fact that a big part of the theme seems to be self expression, I think this is the perfect time to fix this. Not only is it a simple fix of tweaking the texture .png to actually be fully complete (which you could just use mine, its not like its an original idea or anything) but to just fix the texture overlay, heck i'd do it myself if I knew how. 

[media][media]

  

[media]

[media]

 

[media]

 

user-f2760

Unfortunately, entity texture mapping would need to be rewritten in order to fix the issues in your suggested way; unlike block/item models, entity texture mapping is required to have the layout
-UD
RFLB
(up, down, right, front, left, back).
Your suggested layout wouldn't require a resize, yes, but would require a major texture mapping code rewrite, and will likely force Mojang to redefine all existing entity texture mapping, breaking a bunch in the process.

The less time-consuming and less error-prone fix is resizing and moving all the element mappings further apart from each other.

While a do like your fix suggestion, and wish it gets done eventually (eg when mojang creates modifyable entity models), it is too much for a bug fix like this.

Lyle Alexander Artain

@Dhranios While I don't know the technical aspects of remapping the overlay or I guess rezoning, I do know that each mob has a different overlay map for their textures, Mojang would just have to find the coding for the Magma Cube and redo it.

 

Because each mob model is different and has separate overlay mapping for their unique texture, changing the code for the magma cube overlay shouldn't affect any other mob overlay. therefore causing less hassle. The way the magma cube texture is now doesn't even have a layout that would be specific to say mapping left to right. You can tell by how inconsistent the placements are.  

 

But making the file larger would cause many issues as they would have to enlarge all mob textures. 

 

The two inner layers, the patty and tomato that i copied that are correctly made, the sliver under them is the same as the slivers that are inconsistently placed on the top left area overlapping the top under layer and bottom under layer. There aren't any overlapping mapping issues with the patty and tomato layers touching the slivers that make up the outer edges of those layers, so separating pieces more isn't going to solve the issue, especially since there aren't enough pieces there in the first place, as in the overlapping zones aren't the correct size, and even if you separated them you would still have to remap the overlay for the new locations.

 

In short theres no way to fix this without remapping the overlay or rezoning the .png. you can move colors around as much as you want and increase size but the map overlay will stay the same unless edited.

Lyle Alexander Artain

With Block Bench existing maybe that could be used to help mojang fix this?

user-f2760

That is simply not how texture/uv mapping works, only texturing itself. Compare the witch to the villager texture, for example, different sizes, same uv mapping aside from the hat and wart textures.
Making it a bigger texture file only requires the uv mapping for layers to move, while changing the entity UV system entirely to move a single face's UV away from the rest of the element's requires a major structural code rewrite. You seem to be comfusing "make the file bigger" with "scale up the texture".

You really think Mojang didn't already use a program to create entity models before blockbench existed?

limbless

they actually didnt used to use a program at least notch specifically said he manually coded the models when he was explaining how the creeper was made

Lyle Alexander Artain

In Block Bench UV textures can be automatically made, and when these textures are made they include the layers that you wouldn't normally see on the models where the neck meets the body for instance. If these pieces are mapped via UV here without rewriting how the UV works then it's safe to say you could import the magma cube and it should make the correct texture mapping for each of the inner layers of the model. Therefore you wouldn't even need a code rewrite, right? Or would a code rewrite still have to happen? 

 

I'm pretty sure Jeb brought up Notch not finishing something on a minecraft live at one point, but Jeb didn't know what it was, and I think perhaps the Magma Cube texture was the thing that wasn't fully finished, thus why only the layers that the eyes are drawn on are the ones properly mapped in the texture .png.

Lyle Alexander Artain

Here i've used Block Bench to create the correct Magma Cube texture.

[media][media]
Lyle Alexander Artain

Here's a the magma Cube texture using the old texture but in the new correct format. Basically I copied and pasted the old texture for the layers then I repainted the outside using the top and bottom textures as a guide, trying to match the style. So now you can see how the Magma Cube was supposed to look essentially.

 

I give Mojang permission to use this texture for the fix if they want considering it's the majority of the old. 

[media][media]
Lyle Alexander Artain

Heres a Gif so you can see the whole outside.

[media]
[Mod] Jingy

Old Description:

The separate layers of a magma cube's body cannot be properly textured because the top/bottom of a layer UV mapping overlaps the front and left faces of the layers above it, with the exception of the eye layers.

Expected behavior:
Each layer would have their own UV mapping, which does not overlap with anything else. This change would break all existing resource packs that modify the texture (as the texture dimensions would need to be increased), so a pack version number increase would be needed.

Steps to reproduce:

  • Make a resource pack that has the attached magmacube.png as the texture for the magma cube

  • Observe the magma cube's bottom texture, notice that it is green like the left side of the magma cube

Original description:
I was making images for a resource pack I was developing and noticed that the magma cube's texture seems to be rendered incorrectly. In the pictures, you can see that when looking at the magma cube's face, the right side texture gets repeated along the bottom of the magma cube and gets cut off a little bit. I can only assume this was done in error considering the original magma cube file has all 6 sides filled in. As you can see in screenshot 2021-05-12_08.26.02.png, this rendering error makes it a little difficult to properly set up a resource pack in the way that I have here.

Here is a link to download the Resource Pack: https://drive.google.com/file/d/18tAOS8IKKoew_xyhrFp34U-uQSn1kcjP/view

Vulcan Fire

[Mod] Jingy

Chi Wong

1316450

Community Consensus

Expansion B

Normal

Textures and models

magma_cube, overlapping, texture, uv-mapping

1.16.5, 21w19a, 21w20a, 1.19.1, 1.19.2, ..., 1.20.4, 24w09a, 1.20.6, 1.21, 1.21.3

24w44a

Retrieved