mojira.dev
MC-226213

"filled" override in bundle item model no longer allows for values above 1.0

Using a resource pack that changes the model of "overfilled" bundles (using the predicate filled>1.0) no longer works in 21w20a.

{
    "parent": "item/generated",
    "textures": {
        "layer0": "item/bundle"
    },
    "overrides": [
        { "predicate": { "filled": 0.01 }, "model": "item/apple" },
        { "predicate": { "filled": 1.01 }, "model": "item/diamond" }
    ]
}

Reproduce:

1) Create a world in 21w19a and give yourself a filled bundle, and an "overfilled" bundle

/give @s bundle{Items:[{id:'minecraft:stone',Count:1b}]}
/give @s bundle{Items:[{id:'minecraft:stone',Count:65b}]}

2) Enable the attached resource pack

3) Note that the items have unique textures
4) Create a world in 21w20a (or upgrade that world), and the filled and overfilled bundles have the same textures.

Linked issues

Attachments

Comments 5

I cannot reproduce this issue in 1.17 release candidate 1

This is still an issue in 1.17 Release Candidate 2. 

Can you please update the datapack to work with the latest snapshots?

This is no longer an issue in newer versions. The new “item model definition” system’s minecraft:bundle/fullness range dispatch property works for values higher than the normal max fullness.

The attached resource pack (for 25w45a) will make normal bunldes be
- black when empty (0.0 fullness)
- light gray with at least 1 item but less than half full (0.01 - 0.49 fullness)
- white full 1.0 fullness
- magenta for higher than 1.0 fullness

[media]

For the above proof, you can use /give @s bundle[bundle_contents=[{id:stone,count:64},{id:stone,count:32}]] to give yourself an overfilled bundle.

DorkOrc

(Unassigned)

Confirmed

Resource Packs

bundle, filled, fullness, override, predicate, resource-pack

21w20a, 1.20.4, 24w03b, 1.21.1, 24w38a

Retrieved