Fishing bobber retrieving sounds and hand animations aren't played when fishing bobbers are automatically returned from long distances

Code Analysis:

The following is based on a decompiled version of Minecraft 1.20.1 using MCP-Reborn.

net.minecraft.world.entity.projectile.FishingHook.java // Original

public class FishingHook extends Projectile {
    ...
    public void tick() {
        this.syncronizedRandom.setSeed(this.getUUID().getLeastSignificantBits() ^ this.level().getGameTime());
        super.tick();
        Player player = this.getPlayerOwner();
        if (player == null) {
            this.discard();
        } else if (this.level().isClientSide || !this.shouldStopFishing(player)) {
            if (this.onGround()) {
                ++this.life;
                if (this.life >= 1200) {
                    this.discard();
                    return;
                }
            } else {
                this.life = 0;
            }
            ...
        }
        ...
    }    
    ...
    private boolean shouldStopFishing(Player p_37137_) {
        ItemStack itemstack = p_37137_.getMainHandItem();
        ItemStack itemstack1 = p_37137_.getOffhandItem();
        boolean flag = itemstack.is(Items.FISHING_ROD);
        boolean flag1 = itemstack1.is(Items.FISHING_ROD);
        if (!p_37137_.isRemoved() && p_37137_.isAlive() && (flag || flag1) && !(this.distanceToSqr(p_37137_) > 1024.0D)) {
            return false;
        } else {
            this.discard();
            return true;
        }
    }
    ...
}

As we can see in the code, FishingHook#shouldStopFishing is used to determine the distance from the player and the fishing rod. If the distance is too high, it will delete the fishing line, therefore no animations, sounds, and reward comes out of it.

Fix:

To fix this, we can simply remove !(this.distanceToSqr(p_37137) > 1024.0D)) from FishingHook#shouldStopFishing and move it to FishingHook#tick. Then, we can create our own additional "if" statement to check the distance and handle actually animating, rewarding, and emitting sound globally.

net.minecraft.world.entity.projectile.FishingHook.java // Updated

public class FishingHook extends Projectile {
    ...
    public void tick() {
        this.syncronizedRandom.setSeed(this.getUUID().getLeastSignificantBits() ^ this.level().getGameTime());
        super.tick();
        Player player = this.getPlayerOwner();
        if (player == null) {
            this.discard();
        } else if (this.distanceToSqr(player) > 1024.0 D && player.fishing != null) {
            ItemStack itemStack = player.getMainHandItem().isEmpty() ? player.getOffhandItem() : player.getMainHandItem();
            InteractionHand interactionHand = player.getMainHandItem().isEmpty() ? InteractionHand.OFF_HAND : InteractionHand.MAIN_HAND;
            int i = player.fishing.retrieve(itemStack);
            itemStack.hurtAndBreak(i, player, (p_41288_) -> p_41288_.broadcastBreakEvent(interactionHand));
            player.swing(interactionHand);
            player.level().playSound(null, player.getX(), player.getY(), player.getZ(), SoundEvents.FISHING_BOBBER_RETRIEVE, SoundSource.NEUTRAL, 1.0 F, 0.4 F / (player.level().getRandom().nextFloat() * 0.4 F + 0.8 F));
        } else if (this.level().isClientSide || !this.shouldStopFishing(player)) {
            if (this.onGround()) {
                ++this.life;
                if (this.life >= 1200) {
                    this.discard();
                    return;
                }
            } else {
                this.life = 0;
            }
            ...
        }
        ...
    }
    ...
    private boolean shouldStopFishing(Player p_37137_) {
        ItemStack itemstack = p_37137_.getMainHandItem();
        ItemStack itemstack1 = p_37137_.getOffhandItem();
        boolean flag = itemstack.is(Items.FISHING_ROD);
        boolean flag1 = itemstack1.is(Items.FISHING_ROD);
        if (!p_37137_.isRemoved() && p_37137_.isAlive() && (flag || flag1)) {
            return false;
        } else {
            this.discard();
            return true;
        }
    }
    ...
}