[MC-249067] Ominous banners lose their rarity color when renamed using anvils

The bug

When an Ominous Banner is renamed with an anvil, it loses its rarity color. The other items with rarity color can be renamed without losing it.
How to reproduce

[media]

Generate a Pillager Outpost

/place structure minecraft:pillager_outpost

Take an Ominous Banner from the structure
Rename it in an anvil
❌ See if it kept its rarity color after renaming it
Get another item with rarity color (e.g. golden apple) and repeat step 3

Linked issues

is caused by

MC-274657 Ominous Banner's orange name is handled as a custom text color, rather than as a rarity

Attachments

MC_249067.mp4

Comments

muzikbike 2022-03-16T12:35:57Z

This is likely due to it being a custom name color rather than a true rarity color. An easy fix for this would be to split off ominous banners into their own ID (which would fix many other things), and create a proper "Ominous" rarity which applies to them.

ampolive 2022-03-22T19:33:59Z

Relates to MC-123804.

muzikbike 2024-07-25T09:50:13Z

Affects 1.21

muzikbike 2024-07-25T10:00:31Z

Is caused by MC-274657