The Bug:
Calcite can generate outside of amethyst geodes.
Here is an example:
Version: 1.19.3
Seed: -6647368770164400087
Coordinates: /execute in minecraft:overworld run tp @s 262.69 -19.00 -149.67 -133.80 25.20Steps to Reproduce:
Generate a world with the seed provided above and teleport to the given coordinates.
Look closely at the calcite within the amethyst geode.
Take note as to whether or not calcite can generate outside of amethyst geodes.
Observed Behavior:
Calcite can generate outside of amethyst geodes.
Expected Behavior:
Calcite would not be able to generate outside of amethyst geodes.
My suspicion in this bug, as I have seen it many times, is that the Geode generation algorithm does not check for "closedness" and generates a parametric shape to use, placing the layers correspondingly. A possible fix would be to generate Calcite on the outside of all Amethyst Blocks, and Smooth Basalt on the outside of all Calcite blocks, as additionally Amethyst Blocks are very commonly making direct contact with the Smooth Basalt layer.