Villager AI broken when workstation is nearby

I have encountered this bug recently on 1.19.3 server. I have put 3 librarians inside a small room. They froze the moment I placed a lectern and they won't restock either. Removing lecterns unfreezes them.

I can also reproduce this bug. The necessary conditions seem to be that there is more than one villager in the vicinity that has been traded with (i.e. it has a defined profession) and without a current job site or potential job site. When the appropriate jobsite block is then placed where multiple such villagers can path to it, one grabs it as a "potential job site", then it and one other will freeze, neither making any progress towards the jobsite or walking anywhere else.

The frozen villagers will still do other activities such as breeding or sleeping if they can do these without having to walk anywhere. Also, if a third villager meeting the conditions comes close to one of the two frozen villagers, it may take the place of the frozen villager that was farther away.

Looking at decompiled code, I think you may have introduced an error when refactoring YieldJobSite. Prior to 22w45a, the code in part looked like this:

protected boolean checkExtraStartConditions(ServerLevel serverLevel, Villager villager) {
        if (villager.isBaby()) {
            return false;
        }
        return villager.getVillagerData().getProfession() == VillagerProfession.NONE;
    }

In other words, the check returns true only if the villager is not a baby and has no current profession. The AI routine itself has that villager look for a nearby villager having the necessary profession but with no jobsite or potential jobsite, and gives its potential-jobsite claim to that villager.

The corresponding part of the new code looks like this

if (villager2.isBaby()) {
                return false;
            }
            if (villager2.getVillagerData().getProfession() == VillagerProfession.NONE) {
                return false;
            }

In other words, the check proceeds only if the villager is not a baby and does have a current profession. So a villager with the right profession will give its claim up to some other villager, who will then run the same routine to give it back (or pass it on to another, closer villager). And since the act of giving up the claim also clears the villager's walk destination, neither villager goes anywhere as they just trade the claim back and forth.

If I'm right the fix would be simple, just change that == to !=  to restore the prior logic.

I am experiencing this issue on a pure vanilla 1.19.3 server. Villager AI only returns to "normal" after a job block is broken. It's effecting about 15% of my 100 villagers.

Babies and jobless villagers are unaffected.

It's effecting various job roles, from butchers to clerics to fletchers to blacksmiths.

Frozen villagers are missing the "job site" value. Working ones are not.

I have attempted to troubleshoot this by doing the following, none worked:

• Restart the server

• Force time back to 0

• Break beds

• "remove" all other villagers except the problem villagers

• Break blocks around the villager to ensure they weren't stuck via collision

• Teleport the problem villager to their bed

So far, the only method that works to 'solve' the immediate issue is breaking the job block and waiting until all relationships with the block breaks. The villager goes to where the job block was and resumes normal activity. Placing the job block again doesn't always fix the issue, but sometimes it does. 

Below is a screenshot of a correctly working villager, note the job site value circled

Below is a screenshot of a blacksmith who hasn't moved in multiple in-game days. Note the lack of a job site value. All of my problem villagers have "potential_job_site", never "job_site". Seems to support earlier comments regarding the logic for job aquisition.

I'm also having said issue on villagers freezing in my vanilla 1.19.3 survival world.

I discovered 4 Masons not moving around at all in a group. I attempted to solve this issue by breaking the job site and it did unfreeze the villagers. However, placing the job site back in the set locations & other locations would freeze the same 4 villagers. Trying to further solve this issue, I decided to break all job sites and let the villagers sleep. After they've slept, I would have placed them all back down. This solution did not work, 16 out of my 18 Masons are currently frozen.

Checking with the /data command confirmed each villager lost the "minecraft:job_site" or "minecraft:potential_job_site" tags. Placing and replacing the workstations do not let the villagers regain that tag.

Edit: I have added a screenshot of a Mason villager without either tag that is frozen. However, breaking the Stonecutter at the coordinates: ( -486 70 -745 ), the villager will unfreeze. Upon further research, this villager does not have a home location yet can sleep in a bed as well.

same problem in my hardcore world they just stop moving the other vilergers are fine