mojira.dev
MC-266682

Biome sources using inline biomes is not prevented by data pack validation

The bug

When using a biome source that has a biome in inline format, instead of using a reference, the world will fail to generate and lots of errors will show in the log.

How to reproduce

  1. Download the attached data pack

[media]
  1. Create a new world, add the data pack, and click done

  2. ❌ Notice that the data pack validated

  3. Confirm creating the world

  4. ❌ Terrain is not generated and errors are spammed in the log

Expected behavior

The data pack would fail to validate, the codec should not allow inline biomes since a biome ID is required in lots of places.

Error messages

Failed to save chunk 6,-1
java.lang.NullPointerException
Error executing task on Client
java.lang.IllegalArgumentException: No value with id -1
	at hj.b(SourceFile:19)
	at dhu.a(SourceFile:83)
	at dhy.a(SourceFile:175)
	at dhr.a(SourceFile:159)
	at dhq.a(SourceFile:456)
	at fit.a(SourceFile:117)
	at fiy.a(SourceFile:732)
	at fiy.a(SourceFile:697)
	at yg.a(SourceFile:45)
	at yg.a(SourceFile:12)
	at vf.a(SourceFile:23)
	at bfo.d(SourceFile:156)
	at bfs.d(SourceFile:23)
	at bfo.x(SourceFile:130)
	at bfo.bp(SourceFile:115)
	at eqv.d(SourceFile:1231)
	at eqv.f(SourceFile:856)
	at net.minecraft.client.main.Main.main(SourceFile:253)

Linked issues

Attachments

Comments 2

Does MC-263333 describe your issue?

Yes, that sounds like the same issue. Thanks. I even voted for that ticket already 🤦

Misode

(Unassigned)

Unconfirmed

Data Packs

1.20.2, 23w45a

Retrieved