When taking the smithing screen handler's output, "onCraft" is called on an itemstack of unknown source. The mentioned itemstack is either empty (0 air) on quick transfer or the recipe's output stack when the recipe output was taken manually. This results in smithing statistics for mentioned output stack to not be increased.
A screen recording is provided to reproduce this issue as easy as possible.
Attachments
Comments 3
Can confirm in 26.2.
To fix this, ItemCombinerMenu#quickMoveStack should call slot.onTake(player, clicked) instead of slot.onTake(player, slot).
Looking into this, if the contract is trying to be matched between other menus, then the result slot created in ItemCombinerMenu should properly implement onQuickCraft similar to the other result slots (meaning it calls the stats and achievements on the copied click stack), rather than change the parameter for onTake.
Can confirm