mojira.dev
MC-296220

Custom Armor Trim Palettes Are Now Unobtainable In Survival Mode

Issue Explanation

With a data pack and resource pack, you are able to create custom armor trim color palettes. A detailed, step-by-step guide can be found on the wiki and I will also be including the data pack(s) and resource pack that I used to recreate this issue. I will also be referencing a custom echo shard trim color palette often in this report.

In release 1.21.4 and earlier, the item material required to apply a trim color palette to armor was specified by the “ingredient” entry within the game’s files - see examples below.

Vanilla (File Path: 1.21.4\data\minecraft\trim_material\amethyst.json)

{
  "asset_name": "amethyst",
  "description": {
    "color": "#9A5CC6",
    "translate": "trim_material.minecraft.amethyst"
  },
  "ingredient": "minecraft:amethyst_shard"
}

Custom (File Path: Echo-Shard-Trim-Test-Datapack-1.21.4\data\echo_shard_trim_test\trim_material\echo.json)

{
  "asset_name": "echo",
  "description": {
    "color": "#17B4B7",
    "translate": "trim_material.minecraft.echo_shard"
  },
  "ingredient": "minecraft:echo_shard"
}

In 1.21.5, this “ingredient” entry was removed and replaced with the “provides_trim_material” item component. Now, an item must have that item component to be used to apply a trim color palette. Item materials that were already used to apply trim color palettes in Vanilla always have this item component (ex. amethyst shard, diamond, iron ingot). This is not the case for additional items, such as the echo shard example, as it would not have this item component by default. Commands can be used to create/modify items with this item component - see example below.

Vanilla

/give @p minecraft:egg[provides_trim_material="minecraft:amethyst"] 1

Custom

/give @p minecraft:echo_shard[provides_trim_material="echo_shard_trim_test:echo"] 1

The problem is that there is no longer a way to create Survival-Mode-friendly custom trim color palettes. This is because any item material that someone wishes to create a trim color palette for does not have the required item component, “provides_trim_material,” by default and because the old way of achieving this, with the “ingredient” entry in the files, has been removed.

Potential Solutions for This Issue

  • Return the “ingredient” entry to the game’s files, but rework it to set the default ingredient for a custom trim material. That way, the item component can still be used to modify this in-game.

  • Allow us to modify the default components tied to items in general through data packs.

Final Notes

While this may not seem like a major issue, the ability to create custom trim color palettes was a major selling point when armor trims were introduced. Now, that customization is somewhat held back due to this oversight while implementing item components. It's a shame to see this no longer work as initially intended. I’d love to see this fixed soon, especially considering more tweaks will be coming to armor trims with the introduction of copper armor.

Attachments

Comments 9

For the record, the new component is a great idea. However, there is now no way to specify a custom trim material’s “default” ingredient, which is a massive problem.

Please provide all the needed commands to reproduce this issue.

I forgot that I had reported this, sorry.

In-game commands aren’t as necessary to reproduce this issue as data packs are. I have still included some that may help, though. Do you need me to include anything regarding data pack creation?

Side note, I updated the report’s title a bit and description by quite a lot to hopefully make the issue a bit clearer.

Hi. Sorry it’s taken a while to get back to you.

Please can you attach a datapack that can be used to reproduce this?

as well as adding expected/observed results

Below is the download link for the resource pack & data packs for the two versions of the game referenced in the report:

https://drive.google.com/file/d/1gqTm5oRSpM2gjWNXX3y3c1c2BuGxzc30/view?usp=drive_link

Hi.

This appears as a private link and asks me to request access. Please can you also attach a datapack for the latest snapshot?

Not sure why. It wasn’t giving myself or a friend that I tested the link with any problems. I just redid the sharing perms. Try now? I can upload it somewhere else if need be.

I was able to download the pack now.

Skottify

(Unassigned)

Confirmed

Data Packs

1.21.5, 1.21.7, 1.21.8, 25w32a

Retrieved