mojira.dev
MC-296853

The "Shear Brilliance" advancement is incorrectly given by shearing a lead off a wolf

When shearing a lead off a wolf (both tamed and wild), it incorrectly gives the advancement "shear brilliance", which should only be granted when shearing armour off a wolf.

Steps to reproduce:

  • Spawn a wolf and leash it to a fence

  • Use shears on the wolf to remove the lead

Linked issues

Attachments

Comments 1

Can confirm shearing a lead off an unarmored tamed wolf gives the advancement “Shear Brilliance”.

With tamed wolf:

[media]

With wild wolf:

[media]

These observations are further confirmed by analysing the JSON definition of this advancement:

[media]
...
  "criteria": {
    "remove_wolf_armor": {
      "conditions": {
        "entity": [
          {
            "condition": "minecraft:entity_properties",
            "entity": "this",
            "predicate": {
              "type": "minecraft:wolf"
            }
          }
        ],
        "item": {
          "items": "minecraft:shears"
        }
      },
      "trigger": "minecraft:player_interacted_with_entity"
    }
  },
...

The code above suggests that any successful right-click interaction with a wolf (in this case, shearing anything off a wolf) fulfills the advancement’s criteria.

NinjaFighter777

(Unassigned)

1405134

Confirmed

Expansion A

Normal

Advancements

25w16a, 25w20a, 1.21.6 Pre-Release 1, 1.21.6 Pre-Release 2

1.21.6 Pre-Release 3

Retrieved