mojira.dev
MC-312952

Game crash when generating canyons when noise min_y is greater than dimension min_y

When using a custom datapack with noise settings that changes the noise min_y value to one greater than the one defined in the dimension, the game crashes when a canyon generates.

Steps to reproduce

  1. Download attached datapack (modifies data/minecraft/worldgen/noise_settings/overworld.json, by setting min_y to 0)

  2. Generate a new world using the datapack

  3. Fly around

  4. Game should crash with an index out of bounds error when generating a canyon

Attachments

Comments 3

Thank you for helping us improve Minecraft! We saved your files:

[media]
[media]

Attached datapack here.

crash is atCanyonWorldCarver#shouldSkip

At y 0, yIndex is also 0, but the next line reads widthFactorPerHeight[yIndex - 1], which gives the -1 idx from the crash.

WorldCarver#carveEllipsoid uses the output minimum of -64 for its lower bound, so it can pass y 0 here regardless

icanttellyou

(Unassigned)

Unconfirmed

26.4 Snapshot 6

Retrieved