[MC-46417] Sprint particles are generated in spectator mode

The bug

When I was testing the newest snapshot, I tried Spectator mode. I tried to sprint, and I saw sprint particles. The particles is only there if I'm flying on the ground. I'm not sure if other players can see that, but at least the player that's sprinting can see it.

~~As of snapshot 18w07a, sprint particles will continuously appear even when stationary.~~ This doesn't occur in 18w20c anymore.

You can see this when the Particles setting is All or Decreased, but not Minimal.

Code analysis

Code analysis by @unknown can be found in this comment (v2 fixes both MC-46417 and MC-94535).

Linked issues

is duplicated by 8

MC-73087 Spectator Mode - Flying Particles in blocks Resolved

MC-74253 "Running" while flying through blocks in spectator mode will cause spawning particles Resolved

MC-78167 Particles when 'sprinting' in spectator Resolved

MC-79767 Sprinting as a spectator through the ground creates particles. Resolved

MC-112318 Spectator mode particles Resolved

3 more links

relates to 2

MC-73604 Spectator can interact with beacon Resolved

MC-174466 Soul speed particles are generated in spectator mode Resolved

Attachments

Comments 26

kumasasa 2014-02-01T09:28:56Z

Cannot confirm in 13w05b.
Can you attach a screenshot with debug screen (F3) enabled (at daytime please...)

Ruben 2014-02-02T19:21:12Z

Screenshot attached!

Itouch2 2014-02-18T20:21:59Z

Still in 07a

Itouch2 2014-02-19T16:44:03Z

Fixed in 08a

Samuel Kyletoft 2015-06-27T19:31:32Z

Confirmed in 1.8.7
(on realms, if that affects it)

EDIT: Singleplayer too

16 more comments

Ruben 2015-08-17T21:06:03Z

Confirmed for 15w33c as well.

marcono1234 2016-02-18T18:53:13Z

Confirmed for

1.9-pre2

g10r 2016-03-09T16:56:53Z

Affects 1.9

[Mod]Les3awe 2016-06-16T16:22:26Z

Confirmed for 1.10.

Samuel Kyletoft 2016-06-20T15:45:53Z

Works in Creative when flying close to the ground but before you land.
BOTH Java 1.10 and PE/WIN10 0.15

user-f2760 2016-06-20T15:49:33Z

Creative is not the issue here.

Samuel Kyletoft 2016-06-20T16:37:16Z

Technically it is
The problem is when the game decides to render the sprint particles. The issue is that it renders sprinting when the player is sprinting at a set difference in height from the ground.
In gm3 you are always flying so it is an issue, call it a problem or not in gm1 but it is still the same code

user-f2760 2016-06-20T16:54:40Z

Sprint particles in Spectator mode.

I don't see it say creative anywhere, so this ticket is not about the creative sprint particles.

marcono1234 2016-09-23T22:41:23Z

Confirmed for

16w38a

JUE13 2017-04-09T09:22:36Z

Confirmed for 17w14a

Ali M 2017-07-24T19:28:05Z

Confirmed for Minecraft 1.12.

bemoty 2017-08-08T22:17:44Z

Can confirm for Minecraft 1.12.1.

bemoty 2017-08-15T22:24:05Z

The following is based on a decompiled version of Minecraft 1.12 using MCP 9.40pre-1.

This happens because the class net.minecraft.entity.player.EntityPlayer doesn't override the method net.minecraft.entity.Entity.spawnRunningParticles(), which means the game doesn't check if the player is in spectator mode before it spawns running particles. A simple fix would therefore be to override this method and create a simple check if the player is in spectator mode before invoking the supermethod.

net.minecraft.entity.player.EntityPlayer

@Override
public void spawnRunningParticles() {
	if(!this.isSpectator()) {
		super.spawnRunningParticles();
	}
}

Jon1337 2018-02-15T19:31:55Z

confirmed for 18w07b

JUE13 2018-02-17T02:09:53Z

Confirmed for 18w07c

Andy (Romaq) Smith 2018-03-02T04:43:42Z

[media]

Confirmed 18w09a

lord.quadrato 2018-05-19T19:13:23Z

Affects 18w20c; although it does'nt appear when you're stationary anymore, only when sprinting.

Asteraoth 2018-07-16T01:38:02Z

Confirmed for 1.13-pre8

Asteraoth 2018-07-18T19:11:17Z

Confirmed for 1.13

Asteraoth 2018-07-26T19:08:12Z

Confirmed for 18w30b

Maciej Ratyński 2019-08-01T12:14:14Z

Affects 1.14.4

Simple fix:
in `Entity` class in function `spawnRunningParticles` add

if (this.isSprinting() && !this.isInWater())

if (this.isSprinting() && !this.isInWater() && !this.isSpectator())

I also prefer to change it to

if (this.isSprinting() && !this.isInWater() && !this.isSpectator() && !this.isSneaking() && !this.isInLava() && this.isAlive())

so this fix also but with spawning particles after death, when swim in lava, and when someone sneak and sprint (yes, this is possible)