[MC-58177] Night vision rendered darker and orange when nearing light sources with brightness on moody

The bug

When exploring mineshafts using night vision, I found that the blocks nearing light sources always become darker and more orange. But the block just beside the light source is normal.

How to reproduce

Set brightness in video options to minimum
Make/Go to a place with light level 0. (Note: It does something else if exposed to sky, but still looks weird though.)
Get Night Vision effect.
Place any kind of light source.
The blocks near but not beside the light source are rendered darker. (Note: Lava blocks and Fire blocks are rendered too dark too!)

New founds added 6/24:

Finally I got the idea why night vision looks weird under night sky. I found a ravine with a hole above it, and compare to the non exposed area, the place under the night sky are extremely blue.

How to reproduce

Set brightness in video options to minimum
Make (since it's a little difficult to find) a huge (at least 30x10x30) room with light level 0. (Suggested that use stone with some lapis ores)
Get Night Vision effect.
Make sure it's night time in game.
Break a hole on the roof.
Enjoy! Don't forget to try Fire blocks, they look FUNNY!! (?! Just kidding XD)

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is cloned by 1

MC-199559 Light appears darker and orange when Night Vision is active Open

relates to 2

MCPE-116172 Night Vision doesn't work properly under moody brightness Resolved

MC-48666 Cobwebs are affected by block lighting in full sky lighting Open

Attachments

Comments 19

Samuel Klumpers 2014-06-20T17:47:16Z

Is your Java already the latest Java, if it is please add it to the "Java 7" in your environment.

user-f2760 2014-06-20T17:49:22Z

can confirm with brightness on minimal

kumasasa 2014-06-22T20:20:50Z

Somewhat confirmed with brightness on minimum.

Tangent65536 2014-06-25T08:42:47Z

Lava blocks and Fire blocks also have REALLY WEIRD dark blue color! :I

Itouch2 2014-06-25T14:52:13Z

Confirmed for 14w26a and b

9 more comments

Tangent65536 2014-07-07T14:44:25Z

Still a concern in 14w27a and 14w27b.

kumasasa 2014-07-26T07:42:22Z

Is this still an issue in 14w30c ?

Tangent65536 2014-07-29T03:55:04Z

Yes~ It still works for me

Sonicwave 2014-12-25T22:46:11Z

Still an issue up to 1.8.2-pre1.

bob 2016-11-19T23:14:53Z

Can confirm for 1.11. Easiest to see with moody brightness and smooth lighting off.

Ben Staddon 2017-08-29T12:24:39Z

The issue appears to be that some values can be outside of the range expected by the night vision effect code.

Fix is easy, just requires moving the code in EntityRenderer.updateLightmap() a little:

private void updateLightmap(float partialTicks)
{
	// ...
	
	// move this block from here ---
	if (this.mc.player.isPotionActive(MobEffects.NIGHT_VISION))
	{
		float f15 = this.getNightVisionBrightness(this.mc.player, partialTicks);
		float f12 = 1.0F / f8;

		if (f12 > 1.0F / f9)
		{
			f12 = 1.0F / f9;
		}

		if (f12 > 1.0F / f10)
		{
			f12 = 1.0F / f10;
		}

		f8 = f8 * (1.0F - f15) + f8 * f12 * f15;
		f9 = f9 * (1.0F - f15) + f9 * f12 * f15;
		f10 = f10 * (1.0F - f15) + f10 * f12 * f15;
	}

	if (f8 > 1.0F)
	{
		f8 = 1.0F;
	}

	if (f9 > 1.0F)
	{
		f9 = 1.0F;
	}

	if (f10 > 1.0F)
	{
		f10 = 1.0F;
	}
	
	// to here ---

	float f16 = this.mc.gameSettings.gammaSetting;
	float f17 = 1.0F - f8;
	float f13 = 1.0F - f9;
	float f14 = 1.0F - f10;
	f17 = 1.0F - f17 * f17 * f17 * f17;
	f13 = 1.0F - f13 * f13 * f13 * f13;
	f14 = 1.0F - f14 * f14 * f14 * f14;
	f8 = f8 * (1.0F - f16) + f17 * f16;
	f9 = f9 * (1.0F - f16) + f13 * f16;
	f10 = f10 * (1.0F - f16) + f14 * f16;
	f8 = f8 * 0.96F + 0.03F;
	f9 = f9 * 0.96F + 0.03F;
	f10 = f10 * 0.96F + 0.03F;
	
	// ...
}