mojira.dev
MC-74408

The brewing stand GUI does not have container sprites for the fuel and potion output slots

The bug

Some item slot textures in the brewing stand GUI are embedded into the GUI texture rather than using dynamic container sprite textures. This can cause issues such as the item slot texture still being visible after an item has been placed into the slot, and not clearly showcasing what items are applicable for said slot (such as; the brewing stand potion slots).

Possible Fixes & Suggestions

To fix this issue, the solution is to add new sprite textures to assets\minecraft\textures\gui\sprites\container\brewing_stand rather than having them baked into the brewing stand texture. This would have the brewing stand fall in line with the changes made to all GUI textures in snapshot 23w31a.

Below are both the new new sprite textures that could be added:

  • Potion ->

    [media]
  • Fuel ->

    [media]

Linked issues

Attachments

Comments

Dlawso the Really Lucky Rabbit

Can confirm.

yut951121

I think it is WAI, if you change potion bottle texture you can see it's not actually hidden but just seamlessly covered.
See for yourself with this resource pack : https://66ed39aec3765da25cfb6002b5fe7930221b5f18.googledrive.com/host/0Bwh-rUpGiETGWEtvc3E5Rm5zdE0/for%20MC-74408.zip (Virustotal result : https://www.virustotal.com/file/8c40901c939fb8f85c0ae5dff7136d06c801ec0b52abe8fd90c327fba673b324/analysis/1418862189/)

Bentroen

@unknown, that's exactly what I'm saying: it should get hidden - and not seamlessly covered - when you put a bottle on top of it, but it doesn't. I just don't think it works as intended because it doesn't follow the patterns for the other GUIs, like the armor one.

user-f2760

confirmed for 15w31b

Bentroen

Fixed little grammar issue in the title; added 1.8.8.

tryashtar

Still here up through 16w38a. It also applies to the blaze powder slot – try /replaceitem block ~ ~ ~ slot.container.4 ghast_tear to see it easily.

Bentroen

Thanks! I added a screenshot of it.

[Mod] redstonehelper

Note that while ghast tears in that slot are not supported, resource packs giving different textures to blaze powder should still hide the icon.

Oval

Confirmed for 1.13.1.

numeritos

Affects 1.16-rc1

pulpetti

Affects 1.16.1 and 20w27a

Avoma

Can confirm in 21w05b.

Avoma

Can confirm in 1.19.2.

[Mod] Jingy

Requesting ownership for this issue. The original reporter as not updated the issue, and so it has since become outdated and innacurate. I would like to update the post.
Below are some of the things to note now:

1. The player is no longer able to insert anything other than blaze powder into the fuel slot

While the blaze powder texture is still baked into the texture of the GUI, there can no longer be any visual conflicts shown like in "4.png" with the ghast tear.

Source (from BrewingStandMenu class):

public boolean mayPlace(ItemStack itemStack) {
         return mayPlaceItem(itemStack);
      }

      public static boolean mayPlaceItem(ItemStack itemStack) {
         return itemStack.is(Items.BLAZE_POWDER);
      }

2. The armor and off hand slot background/borders in the player inventory GUI texture are no longer baked in, but rather dynamically uses item textures now

Textures used:
empty_armor_slot_helmet.png
empty_armor_slot_chestplate.png
empty_armor_slot_leggings.png
empty_armor_slot_boots.png
empty_armor_slot_shield.png

3. The llama & horse GUI texture are the same

Both entities share the same GUI texture, which currently does not allow for the item slots to render dyanmically.

(Currently though, this is less of an issue as there are no visual issues with this GUI. All the applicable item textures allign with their slot backgrounds)

4. The Enchantment table GUI texture recently updated and still has the lapis lazuli texture baked in

This is not necessarily an issue, but is relevant to the report still.

5. The Smithing table GUI texture no longer has this issue

The smithing table got an overhual, and no longer has the issue as all the item slots render dynamically.

user-f2760

Smithing table is no longer affected.

[Mod] Jingy

(Leaving a comment to note me updating the post)
This issue is no longer present for the enchanting table, or the horse/llama gui textures as of 23w31a. The only GUI affected by this issue now is the brewing stand. (Which notably is the only GUI not changed in 23w31a)

(Old title: Dynamic rendering of item slot textures is not consistently used for all GUIs)

[Mod] Jingy

Requesting that 1, 2, 3, and 4.png be removed from the issue as they are no longer related, and provide no valuable information.

user-f2760

That's because you kinda changed the scope of the report from not hiding to not separate. Seeing recent changes, that's fine (since it's no longer 1:1, and a separate report for the not hiding got made), but those images were relevant to the report.

Take this as a reminder that changing scope is generally not to be done to a report.

[Mod] Jingy

I'll remember that, thanks for letting me know. 👍

muzikbike

For the record, that ticket is MC-265033, which should absolutely be marked as related.

muzikbike

This has somehow made it into the full release of 1.20.2.

Bentroen

[Mod] Jingy

gegy

Confirmed

Platform

Low

Textures and models, UI

brewing_stand, gui, inconsistent-textures, resource-pack-support, texture

Minecraft 1.8, Minecraft 1.8.1-pre4, Minecraft 1.8.1-pre5, Minecraft 1.8.1, Minecraft 1.8.2-pre1, ..., 24w07a, 24w09a, 1.20.5, 1.20.6, 24w20a

24w44a

Retrieved