mojira.dev
REALMS-11807

Realms deletes files in data packs that use experimental features

After uploading the world folder containing the datapacks to realm, files in the datapacks folder are incorrectly deleted, causing datapacks to not work properly.

What I expected to happen was...:
After uploading the world folder to the realm, the files in the datapack will not be deleted and the datapack will function normally.

What actually happened was...:
After uploading the world folder to realm, the files in the datapack are deleted as useless and the datapack does not function properly.

Steps to reproduce:

  1. Upload world file with a datapack to a Realm.

  2. Enter the Realm and notice that the datapack does not function correctly.

  3. Downloading the world folder from realm and looking at the realms-upload.log file in it reveals that some files were deleted as useless.

Linked issues

Attachments

Comments 10

This problem also exists in Snapshot.

After updating realm to 1.21 Pre-4, more files in datapack were deleted by mistake.

I tried to reproduce this with the datapack provided in REALMS-11851, and it does indeed look like some files are being disregarded, but I don't know if that's wrong or not.

realms-upload.log

Removed datapacks/playerheaddrops.zip/playerheaddrops/pack.mcmeta: not used
Removed world/DIM-1/data/raids.dat: not used
Removed world/playerdata/496bea7a-5917-4bee-8044-929f767dd7c9.dat_old: not used
Validated 16 files, 13 accepted, 3 rejected.

@unknown: For further internal investigation, could you attach your data pack that generates

[media]

?

This ticket will automatically reopen when you attach the data pack.

@turbo Sure, I've uploaded my datapack.

Hi again, after playing around with your datapack, I'm coming to the following result:

realms-upload.log

Removed datapacks/Arknights.zip/changelog.md: not used
Removed datapacks/Arknights.zip/data/arknights/damage_type/magical.json: not used
Removed datapacks/Arknights.zip/data/arknights/damage_type/physical.json: not used
Removed datapacks/Arknights.zip/data/arknights/damage_type/pure.json: not used
Validated 248 files, 244 accepted, 4 rejected.

Credits go to @unknown on Discord for the following:

I think this is mostly related to REALMS-5322. They don't want experimental stuff on realms, which does include damage types (you get the experimental warning in singleplayer). I think there are other reports for non-worldgen stuff I couldn't find quickly.

The function files being rejected is probably a incompatible datapack (i.e. a 1.21 snapshot datapack uploaded to a 1.20.6 realm), see REALMS-11834 for the fix of that (1.21 renamed the folder from functions to function)

Damage types are considered experimental content as per MC-260452.

I have understood the issue about damage_type, it is an experimental features so not supported by realms. But the other functions that were deleted by mistake, in fact I have renamed the folder according to the format of the 1.21 update (e.g. functions changed to function), but they were still deleted as useless files. I think it's the useless file deletion mechanism of realms that has not been updated in time.

The thing is, I cannot reproduce

[media]

in 1.21. Can you still reproduce this? You reported this at a time before 1.21 was released.

I retried and now the function doesn't get deleted anymore. Thank you, now all I can do is wait for Mojang to remove damage_type from experimental features.

Thank you for the update, this issue is being closed as Invalid. This report does not describe a bug.

DDA

(Unassigned)

Confirmed

Java

Retrieved