mojira.dev

James Puleo

Assigned

No issues.

Reported

No issues.

Comments

@Megalodab somewhat.

The mechanic works the same. However, the knockback applied is different. See my updated write up for more information.

As slicedlime stated, they only intended to fix the division by 0 problem. To achieve this, they simply clamped one of the values to make sure it cannot become too close to 0. However, this changes the vector math applied as knockback, making certain values unreachable.

The most knockback possible to be applied is around 120.0 (on one axis) due to the nature of this change.

I made a write-up about the exploit here: https://gist.github.com/electricman226/6f21267666001d653ce56749866e4d9e (more detailed info)

I'd consider this somewhat❓ of a security concern, seeing as this has the possibility of timing out players/crashing the server due to the watchdog closing it after too long of a tick/too many ticks missed.

The fix for this is either to change the math, or clamp the existing math and add divide by zero checks.

If you could, remove your 'Update' from the issue, because those conditions are simply wrong. The write-up shows how it's triggered/required conditions.