mojira.dev

UncleMion

Assigned

No issues.

Reported

MC-6551 Creative Menu potion values are not the same as when brewed (issue redo) Fixed MC-1846 First-person perspective parallax problem Fixed MC-1705 Creative Menu potion values are odd, not the same as when brewed Duplicate

Comments

I always assumed the floating was a representation of "creeping", since sneaking players also "float" 0.125m over the ground like that. Not clear to me why it required "fixing".

EDIT: Ah, it looks like the player floating while sneaking also got "fixed" in a recent snapshot. No worries since at least that's being consistent, but I wonder if anyone asked Notch if the floating while creeping/sneaking was on purpose.

I've noticed the problem with the target syntax

@a[name=!<username>]

myself. It only occurs when there's more than 1 person connected to a server, as you noted; it also happens with LAN sessions with additional people connected.

Checking the source for Minecraft 1.5.1 (decompiled with MCP 7.44),
the problem is in the method ServerConfigurationManager.findPlayers:

if (par9Str != null)
                {
                    var17 = par9Str.startsWith("!");

                    if (var17)
                    {
                        par9Str = par9Str.substring(1);
                    }

                    if (var17 == par9Str.equalsIgnoreCase(var16.getEntityName()))
                    {
                        continue;
                    }
                }

This is in a loop; the first time through it's okay, but since it removes any leading ! from par9Str, it won't work any additional times - in fact, for any player after the first one, it will act as though the command target was

@a[name=<username>]

The solution? Don't change par9Str, make a local String variable and change that instead:

if (par9Str != null)
                {
                    String tmp = par9Str;
                    var17 = tmp.startsWith("!");

                    if (var17)
                    {
                        tmp = tmp.substring(1);
                    }

                    if (var17 == tmp.equalsIgnoreCase(var16.getEntityName()))
                    {
                        continue;
                    }
                }

The same applies to the team name check on par10Str.

I can confirm this bug. I had to fix it for my resizing mod to work properly, after it kept causing "illegal stance" errors in multiplayer.

(Using MCP v7.25 on Minecraft 1.4.6)

The piece of code that needs to be changed is in the Entity.moveEntity method, in the part right before the Profiler section "rest", just before where Entity.ySize gets changed:

double var40 = this.boundingBox.minY - (double)((int)this.boundingBox.minY);

The "(double)(int)" causes the player to glitch through to the bottom of the short block before getting popped back up. My fix was this:

double var40 = this.boundingBox.minY - var29.minY;

Where "var29" was the copy of the entity's bounding box made before checking block collisions:

AxisAlignedBB var29 = this.boundingBox.copy();

I hope this helps 🙂

The FOV seems fine, even with Quake Pro. I don't get the "seeing through the world" problem when walking close to blocks when view-bobbing.

It may feel like you're "too close" when standing right up against a block if you're not used to it, but if you go into 3rd-person, the block area covered by your head is pretty close to the FOV area in first-person, so it's probably okay.

I've also noticed that the drinkable Potion of Healing & Potion of Harming are not in the creative menu. They seem to map to the same potion effects as their splash versions, probably since they're instant.

Updating the description with a bit of MCP code that does the job of covering both the splash & non-splash instant potions and using the smallest potion value for each effect.

(Maybe you could make MC-1517 the duplicate instead of this issue, considering that this has more detail and a fix?)

See MC-1705 for more details on this problem with potions, the likely cause, and a possible fix.

Hmm, although MC-1517 is describing the same sort of problem, my issue description has a lot more info and an explanation. Is there a good way to say "look at MC-1705 for gory details"?

This issue probably duplicates MC-1517.