[MC-1003] Stairs in Desert Temple are not facing the right way

When I was walking on a piramid I founded this stairs in a wrong way

Linked issues

is duplicated by 4

MC-3603 Stairs in Desert Temples don't look right (in both towers lowest stair block) Resolved

MC-5469 World generating bug, desert temple Resolved

MC-16545 Bug in the generation of Dessert Temples Resolved

MC-31296 Bad desert temple generation Resolved

relates to 2

MC-12918 Chests within jungle temples can generate facing in incorrect directions Open

MC-135048 Misplaced sandstone block on desert temple Resolved

Attachments

Comments 18

kumasasa 2012-10-28T10:03:20Z

For the sake of searchability: " Pyramid "

Richard Cox 2012-10-28T10:06:53Z

Was this a newly generated world or newly generated block in an existing world; or a already generated block from a pre-1.4.2 world?

Darren Hiles 2012-10-28T14:07:14Z

This behaviour comes from the new stair wrapping. The lower set of stairs is convinced it should be wrapping hence the small square on top. The stair isn't actually the wrong way it just appears to be due to the half slab next to it.

Selbram (Tory Clement) 2012-10-28T15:18:53Z

Edited title for clarity.

Chalmes (Jon) 2012-10-28T19:55:57Z

Just wanted to add that this doesn't happen in all pyramids and may also be affected by the pyramids orientation.

8 more comments

Chalmes (Jon) 2012-10-28T23:33:03Z

Ok, so the issue is that the block underneath the one highlighted in my screenshot is a stair block instead of a sandstone block. Its orientation is always with the lower part of the stair block facing West, irrespective of which direction the door of the pyramid is facing, so it gives varying results.

Ezekiel 2014-01-22T14:27:54Z

Is this still a concern in the latest Minecraft version 14w03b? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Symon Roberts 2014-01-24T22:57:17Z

I can confirm this is still in 14w04b, but I'm not sure how to update the affected versions.

S P 2014-08-24T13:00:52Z

Confirmed in 1.8-pre1

Sonicwave 2015-01-15T06:10:05Z

Does this still affect the current version/snapshot 1.8.1/1.8.2-pre1?\

bob 2015-02-21T17:16:28Z

Can confirm for current version 1.8.3-it has such a simple fix too!
In the structure builder for the desert temple: (MCP plus own mappings)

ComponentScatteredFeaturePieces$DesertPyramid.java

/*...generating column entrances*/
/* 127:218 */     fillBorderedArea(paramWorld, theBoundingBox, 2, 4, 4, 2, 6, 4, Blocks.air.getDefaultState(), Blocks.air.getDefaultState(), false);
/* 128:219 */     fillBorderedArea(paramWorld, theBoundingBox, this.scatteredFeatureSizeX - 3, 4, 4, this.scatteredFeatureSizeX - 3, 6, 4, Blocks.air.getDefaultState(), Blocks.air.getDefaultState(), false);
/* 129:220 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(eastStairs), 2, 4, 5, theBoundingBox);
/* 130:221 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(eastStairs), 2, 3, 4, theBoundingBox);
/* 131:222 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(eastStairs), this.scatteredFeatureSizeX - 3, 4, 5, theBoundingBox);
/* 132:223 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(eastStairs), this.scatteredFeatureSizeX - 3, 3, 4, theBoundingBox);
/* 133:224 */     fillBorderedArea(paramWorld, theBoundingBox, 1, 1, 3, 2, 2, 3, Blocks.sandstone.getDefaultState(), Blocks.sandstone.getDefaultState(), false);
/* 134:225 */     fillBorderedArea(paramWorld, theBoundingBox, this.scatteredFeatureSizeX - 3, 1, 3, this.scatteredFeatureSizeX - 2, 2, 3, Blocks.sandstone.getDefaultState(), Blocks.sandstone.getDefaultState(), false);
/* 135:226 */     setBlock(paramWorld, Blocks.sandstone_stairs.getDefaultState(), 1, 1, 2, theBoundingBox);
/* 136:227 */     setBlock(paramWorld, Blocks.sandstone_stairs.getDefaultState(), this.scatteredFeatureSizeX - 2, 1, 2, theBoundingBox);
/* 137:228 */     setBlock(paramWorld, Blocks.stone_slab.getStateFromMeta(BlockStoneSlab$EnumType.SAND.getMeta()), 1, 2, 2, theBoundingBox);
/* 138:229 */     setBlock(paramWorld, Blocks.stone_slab.getStateFromMeta(BlockStoneSlab$EnumType.SAND.getMeta()), this.scatteredFeatureSizeX - 2, 2, 2, theBoundingBox);
/* 139:230 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(southStairs), 2, 1, 2, theBoundingBox); //THIS SHOULD BE Blocks.sandstone.getDefaultState()
/* 140:231 */     setBlock(paramWorld, Blocks.sandstone_stairs.getStateFromMeta(northStairs), this.scatteredFeatureSizeX - 3, 1, 2, theBoundingBox); //THIS SHOULD BE Blocks.sandstone.getDefaultState()

It's literally a two-line fix. LINES: 139 and 140

bob 2015-02-21T17:18:24Z

Can only mods add affected versions?

Dlawso the Really Lucky Rabbit 2015-02-21T17:20:59Z

bob, ony moderators and the person who reported it can add affected versions.

bob 2015-02-21T17:21:50Z

marcono1234 2015-06-17T15:19:14Z

~~Cannot confirm for 1.8.7 the stairs are now rotated correctly~~, however I am not sure if it is intended that there is a slab on top of a stair

Confirmed for

1.8.7 I assume they face always in positive z-direction

bob 2015-06-17T19:14:23Z

Slab should be on top of a full block or the stair should at least have a consistent orientation. Can you post a screenshot of the current behaviour?

Alexander 2015-10-30T18:59:43Z

Fixed, no longer a concern as of 15w44b.

Tested 15 temples across two identical worlds with the same seed, on both 1.8.3 and 15w44b. Stairs only generated wrongly in 1.8, but behaved correctly in the snapshot.

[Mod] redstonehelper 2015-10-30T19:07:28Z

Fixed in some snapshot.