[MC-100991] Killing entities with a fishing rod doesn't count as a kill

The bug

When you yank someone into the lava or yank them from a high place to make them fall, it doesn't count as a kill. It just says the message as if the player killed him or her self rather then the fishing rod user killing the player. And it doesn't increment the player's stat.playerkills and the totalKillCount score.

Code analysis

Code analysis by @unknown can be found in this comment.

Linked issues

is duplicated by 1

MC-225794 Death by fall damage caused by reeling in an entity no longer counts as a player kill Resolved

relates to 2

MC-113006 Items reeled in with fishing rod do not move smoothly but appear to teleport Reopened

MC-113818 Fishing rod cannot pull XP orbs Open

Attachments

Fishingrodkillbug-1.m4v

Comments 6

marcono1234 2016-04-16T20:42:34Z

The reason why this is happening is because the class net.minecraft.entity.projectile.EntityFishHook is not dealing damage to the player. This way the CombatTracker does not track this. The method net.minecraft.entity.projectile.EntityFishHook.func_184527_k() (pulling an entity) could for example get the CombatTracker of the caught entity and make it track this event.

The following only shows an example, however the damage type is not completely correct.

protected void func_184527_k()
{
    double d0 = this.angler.posX - this.posX;
    double d1 = this.angler.posY - this.posY;
    double d2 = this.angler.posZ - this.posZ;
    double d3 = (double)MathHelper.sqrt_double(d0 * d0 + d1 * d1 + d2 * d2);
    double d4 = 0.1D;
    this.caughtEntity.motionX += d0 * d4;
    this.caughtEntity.motionY += d1 * d4 + (double)MathHelper.sqrt_double(d3) * 0.08D;
    this.caughtEntity.motionZ += d2 * d4;
    
    // Added this
    // Imported net.minecraft.entity.EntityLivingBase
    if (this.caughtEntity instanceof EntityLivingBase) {
        EntityLivingBase entityLivingBase = (EntityLivingBase) this.caughtEntity;
        
        entityLivingBase.getCombatTracker().trackDamage(DamageSource.causeThrownDamage(this, this.angler), entityLivingBase.getHealth(), 0f);
    }
}

There is however a problem that the CombatTracker resets pretty fast.

Logical_Cyclops 2016-04-17T14:27:37Z

I'm quite surprised that barely anyone has noticed that this is a bug; but it might be because not a lot of people have realized that the fishing rod got updated to yank people properly. It's super ironic to me that my ticket isn't marked as a duplicate, because I really did expected for there to be a already reported ticket that I probably couldn't find in the search engine, and I think I've might of found another bug with the fishing rod, which I'll need to do further testing before I can report it.

marcono1234 2016-04-17T15:22:00Z

I did not notice it myself, I just saw the report and got interested 🙂

Is the other bug maybe MC-87988?

Logical_Cyclops 2016-04-17T15:31:00Z

No, it's this one:MC-101033

Avoma 2020-11-29T18:05:25Z

Can confirm in 20w48a. I've attached a video of this occurring.

Brevort 2021-05-21T20:13:54Z

Occurs with mobs as well per MC-225794.