[MC-101240] Climbing statistic only registers upward movement

The bug

The minecraft.custom:minecraft.climb_one_cm statistic will only increment when the player climbs upwards, not downwards or sideways.

Steps to Reproduce:

Run the following commands:

/scoreboard objectives add climb minecraft.custom:minecraft.climb_one_cm
/scoreboard objectives setdisplay sidebar climb
/scoreboard players set @a climb 0

Climb downwards or sideways whilst on a ladder.
→ ❌ Notice how the score does not increase.

Code analysis

Code analysis by @unknown can be found in this comment.

Attachments

Comments 18

user-f2760 2016-04-23T21:53:53Z

Possibly intended, climbing Means gaining hight, climbing a ladder/mountain/etc.

KingSupernova 2016-04-23T22:36:32Z

It can also refer to a descent. "He climbed down the ladder" is a legitimate use of the word.

user-f2760 2016-04-23T22:39:53Z

True, that's why I said "possibly intended" but in general, climbing means gaining hight, and the real term for your sentence would be "decend from the ladder" but that barrely ever gets said.

Avoma 2020-11-29T18:11:43Z

Can confirm in 20w48a. I've attached a video showcasing this bug in action.

Avoma 2021-02-03T12:07:05Z

Can confirm in 21w03a.

8 more comments

Avoma 2021-02-07T11:43:28Z

Can confirm in 21w05b. Here are some steps to reproduce this issue:

Steps to Reproduce:

Run the following commands:

/scoreboard objectives add climb minecraft.custom:minecraft.climb_one_cm
/scoreboard objectives setdisplay sidebar climb
/scoreboard players set @a climb 0

Climb downwards or sideways whilst on a ladder.
→ ❌ Notice how the score does not increase.

Chandler 2021-02-08T21:24:45Z

The code found at net.minecraft.entity.player.PlayerEntity.increaseTravelMotionStats() (Based on 21w05b yarn mappings) only checks for a positive difference in Y movement as seen here, which would need to be changed to check for any difference in any direction:

public void increaseTravelMotionStats(double dx, double dy, double dz) {
        . . .
        if (this.isClimbing()) {
            if (dy > 0.0) {
                this.increaseStat(Stats.CLIMB_ONE_CM, (int)Math.round(dy * 100.0));
            }
        }
}