mojira.dev
MC-10534

Big oak trees don't spawn

Large oak trees don't spawn, they're replaced with some strange trees.

Linked issues

Attachments

Comments

Capopanzone

You can see the seed I used, so you can reproduce easily.

kumasasa

Coordinates ?

CubeTheThird

Related to MC-2759?

Fjodor Dostojewski

I've got the same trees as in the picture when I try to reproduce. How could I know, that kind of trees should be large oak trees?

@Kumasasa: It's directly at your spawn point.

Seed for Copy&Paste: -753548930

bugi74

The summary is a bit misleading; with that seed, even the same forest has many big trees (branches and all). Checking out the tree big generator code next, but I think already that those smaller "big trees" are just smallest versions of what that generator can produce.
Edit: yeppers. Those two samples (and others like it), are created as "big trees" with height limit of just 7, and no branches or side "bushes" of leaves. Just the one main ball of leaves. With manual growing, I've seen as short "big trees" as 6.

However, while testing, I noticed that the randomization of tree heights during world generations is bit poor. Long sequences of trees of only height 10, then long sequence of only 11, then bunch of 7, etc. This may make it look like that some area has no big trees, as there can be local group of less big ones.

Edit2: Hah, its another bug; the tree height is accidentally remembered from the generation of the previous tree (as it reuses the same generator instance). The height only changes occasionally, as a side-effect of a routine that checks how tall it can be in the intended location. But this is worthy of another issue.

In any case, the chance to generate such small "big trees" with no branches looks like somewhat intended feature.

Capopanzone

It seems to be fixed in 13w10a.

bugi74

I don't think it is fixed in 13w10a, as using 1.5 pre, I get exactly the same small "big trees" in that same world sampled in this issue. In order to get those exact same trees, the generator code has to be pretty much the same as before, the bugged stuff.

Note that the issue is "hidden" when growing trees from saplings. It affects trees generated as part of the world generation process.

It would be good to change the issue summary to something like "Big tree generator's height randomization is broken", which describes the root issue. (The current summary of big trees not spawning at all is simply not true and never was - they just spawned the shortest versions. Amount of the shortest ones depending on the world).

Alternately, I can just create a new issue for that. EDIT: Oh wait, I think I already did create another issue for that 😛 Damn, my memory is soooo... Yes, found it.

bugi74

Could a moderator link this issue to MC-11208 (which is the cause for this one).

Tails

Resolved as duplicate of MC-11208.

Capopanzone

(Unassigned)

Unconfirmed

Snapshot 13w09b

Retrieved