[MC-106684] map_scale_direction tag is not read when filled map is created using commands

The bug

The tag map_scale_direction is only read from a filled_map if it was created by scaling an existing filled map, but cannot be set when creating a filled_map item.

Note: This report is likely invalid because the tag map_scale_direction is only used internally and possibly also slightly hacky.

How to reproduce

Use the following command
```
/give @p filled_map{map:32767}
```
Look at the map, its scale should be 3/4

Replace "###" with the data value of the map you just gave you (shown as "Id #X" in the hover text)

/setblock ~ ~ ~ furnace{Items:[{Slot:2b,id:"filled_map",Count:1b,tag:{map_scale_direction:1,map:###}}]}

Take the map out of the furnace
Look at the map
→ map_scale_direction affected the map and its scale became 4/4
Use the following command
```
/give @p filled_map{map:32767,map_scale_direction:1}
```
→ ❌ The scale is the default 3/4 instead of 4/4

Comments 2

user-f2760 2023-03-14T15:15:52Z

This is partially broken in 1.19.3 still, it does display the proper scaling in the lore, but the map number remains un-set unlike the furnace, and it uses the normal map scaling upon viewing. I did have to change the steps a little bit, by creating a map 0, and then using "map:0" in all commands, as map 32767 didn't function.
Affects 1.19.3 and 1.19.4-rc3.

CreeperFriend 2024-04-06T23:47:31Z

This seems to be "fixed" / cannot be reproduced anymore in 24w09a. The map_scale_direction tag cannot be used in commands as of that snapshot. Maps that had this tag and are loaded into 24w09a will convert it into a custom data tag.

It should also be noted, that (before 24w09a) after the map is scaled, the tag would be removed from the map, explaining why the tag wouldn't be read on the second give command.