[MC-107224] World border death message states "suffocated in a wall"

The bug

When you die because of being outside the confines of the world border, the death message states "player suffocated in a wall", which is incorrect. The player isn't in a wall, so it shouldn't mention it.

Linked issues

relates to 2

MC-21520 Death message for /kill is "<player> fell out of the world" Resolved

MC-107149 maxEntityCramming death message states "suffocated in a wall" Resolved

Attachments

Comments 20

migrated 2017-11-10T11:10:28Z

Please do not mark unreleased versions as affected.
You don't have access to them yet.

migrated 2019-10-03T01:36:09Z

I do think it should say "fell out of the world" akin to the /kill command, but I'm quite confused as to why this would have constituted an issue request. If it's existed for so long it's very obviously not a bug.

Avoma 2020-11-28T15:52:12Z

Can confirm in 20w48a. I've attached a video of this happening.

Avoma 2021-01-25T08:26:58Z

Can confirm in 21w03a.

Avoma 2021-02-07T12:36:56Z

Can confirm in 21w05b.

10 more comments

Avoma 2021-02-14T15:33:53Z

Can confirm in 21w06a.

Avoma 2021-02-16T16:08:00Z

Video attached.

Avoma 2021-02-22T12:23:26Z

Can confirm in 21w07a.

Avoma 2021-03-29T14:33:16Z

Can confirm in 21w11a. Relates to MC-21520.

Avoma 2021-04-25T09:58:31Z

Can confirm in 21w16a.

Avoma 2021-04-29T07:20:46Z

Most likely a feature request due to the resolution of MC-21520.

Avoma 2021-07-15T11:14:47Z

Can confirm in 1.17.1.

Avoma 2021-12-31T15:58:45Z

Can confirm in 1.18.1.

Avoma 2022-01-21T16:59:12Z

Here's a code analysis of this issue.

Code Analysis:

The following is based on a decompiled version of Minecraft 1.18.1 using MCP-Reborn.

net.minecraft.world.entity.LivingEntity.java

public abstract class LivingEntity extends Entity {
   ...
   public void baseTick() {
      ...
      if (this.isAlive()) {
         boolean flag = this instanceof Player;
         if (this.isInWall()) {
            this.hurt(DamageSource.IN_WALL, 1.0F);
         } else if (flag && !this.level.getWorldBorder().isWithinBounds(this.getBoundingBox())) {
            double d0 = this.level.getWorldBorder().getDistanceToBorder(this) + this.level.getWorldBorder().getDamageSafeZone();
      if (d0 < 0.0D) {
         double d1 = this.level.getWorldBorder().getDamagePerBlock();
               if (d1 > 0.0D) {
                  this.hurt(DamageSource.IN_WALL, (float)Math.max(1, Mth.floor(-d0 * d1)));
               }
            }
         }
         ...

If we look at the above class, we can see that the damage source of damage dealt to entities when outside of the world border is IN_WALL. This is evident through the following line of code:

this.hurt(DamageSource.IN_WALL, (float)Math.max(1, Mth.floor(-d0 * d1)));

As a result of taking IN_WALL damage, the death message "PLAYER suffocated in a wall" is displayed.

muzikbike 2022-02-19T18:48:28Z

Also likely relates to MC-17019.

Avoma 2022-03-05T11:46:38Z

Can confirm in 1.18.2.

Avoma 2022-06-20T11:47:05Z

Can confirm in 1.19 and 22w24a.

Avoma 2022-09-12T16:58:57Z

Can confirm in 1.19.2.

[Mod] ManosSef 2023-05-10T18:45:55Z

Fixed in 1.20-pre1.

migrated 2023-05-10T19:36:21Z

Yeah, this is fixed in 1.20-pre1. Interestingly, MC-21520 is fixed as well, despite being classfied as "Invalid".