Top of high woodland mansion corridors do not replace old blocks

Still in 16w40a

Still in 18w50a.

Still in 20w13b.

Confirmed for 20w51a, using -1681023348413992357 at

/execute in minecraft:overworld run tp @s -9733.12 79.09 -11204.36 -1963.02 -54.68

If you don't mind, uriel, may I get the report back?

Can confirm for 1.16.5. Relates to MC-140727.

No it's not; this is a certain section of blocks not replaced with air, that is post-structure generation blocks being placed inside.

It's actually the same issue. Grass generates, and then structures don't replace blocks inside them with air.

As shown in MC-223305, structures generate after plants. Otherwise, you wouldn't see only the top part of tall grass generating.

I suggest keeping either this issue or MC-140727, and using a better name, such as "Some structures don't replace terrain inside them with air".

The fix is correct that a woodland_mansion:corridor_floor_hight.nbt piece needs to be made that is 3 blocks taller. In code, within the WoodlandMansionPieces$MansionPiecePlacer.createMansion method,

list.add(new WoodlandMansionPieces.WoodlandMansionPiece(this.structureManager, "corridor_floor", blockPos3, rotation));

should be replaced with 

list.add(new WoodlandMansionPieces.WoodlandMansionPiece(this.structureManager, (floorIndex == 0 ? "corridor_floor" : "corridor_floor_high"), blockPos3, rotation));

That way the second and third floors of the mansion can use the taller corridor floor piece that can replace the terrain in the 3 block taller hallways. 

 This problem exists in 1.18 Pre 7. In one area the terrain generates floor to sealing even taking out part of the floor. Also added pics of a bunch of areas I found. Seed is 4132146605620838058 on pre release 7

Also terrain is generating on the lower roof on the outside.

That screenshot is a different bug than this one (MC-107637); there's no structure piece at all being placed there.
It would be best if you added that screenshot there, and removed it here.

Can confirm this behavior in 1.18.

Version: 1.18

Seed: -5390996534419274646
Coordinates: /execute in minecraft:overworld run tp @s 2982.37 75.51 -1976.85 -108.18 -14.26

Can confirm in 1.18.2.

Version: 1.18.2

Seed: 5674588914129534515
Coordinates: /execute in minecraft:overworld run tp @s -3479 123 2998 265 -32

Affects 22w14a:

Can confirm in 1.19 and 22w24a.

Version: 1.19

Seed: 4373241205666815302
Coordinates: /execute in minecraft:overworld run tp @s 401167.03 72.05 8267.53 -109.59 -25.13

Version: 22w24a

Seed: -1218851612612966176
Coordinates: /execute in minecraft:overworld run tp @s 108084.91 73.09 9770.00 268.94 -16.12

An attachment with a disallowed file extension has been removed from this ticket.

Executable files and documents are not allowed as attachments.
Please attach crash reports, log files and screenshots as they are instead of pasting them into a document.
_{-- I am a bot. This action was performed automatically! If you think it was incorrect, please notify us on Discord or Reddit}