[MC-223305] Fix for various world generation issues

These issues seem to have a different cause. Please close this report for now.

Currently, there are multiple categories of features in the game, such as lakes, vegetation and ores. They are all generated in a specific order that isn't very logical, causing various generation problems.

Some of the features expose blocks (lakes, structures and springs). To make sure certain ores are 100% hidden (debris, large diamond ore), they should generate after those features, at the point where no more air/water generates.

I'm suggesting a new order for the features, and the reasoning for it. I'm using the feature categories named here: https://minecraft.fandom.com/wiki/Biome/JSON_format. I omitted some categories that don't cause problems.

Feature	Fixes
1. Caves
2. Aquifers
3. `LAKES` * they generate pockets in the terrain, functioning like mini-caves they expose stone - important for cave biome features and ores placed after aquifers because they could have lava
4. `UNDERGROUND_STRUCTURES` - geodes, fossils, dungeons
5. Structures	should generate after caves - fixes MC-170897 (fossils generate their own support islands, which get carved by caves) should generate after lakes - fixes MC-81467, MC-107916, MC-199555 should generate after underground structures - fixes MC-206648
*features that generate liquids - springs (was in `VEGETAL_DECORATION`) can expose blocks - not that big of a deal since they're small, but if the intention is to have some ores 100% hidden, it would count as a bug to have them later; they could be moved at the beginning of the ores category

— no more blocks are exposed after this| |

6. UNDERGROUND_ORES + UNDERGROUND_DECORATION - features that replace existing blocks: ores, stone blobs, soil disks

should generate after structures - fixes MC-181779 (1/2)
- some structures (mineshaft, fortress) can expose ores that would otherwise be hidden

7. TOP_LAYER_MODIFICATION - freezes water, adds snow on top

should generate after lakes - fixes MC-132306

8. VEGETAL_DECORATION - surface features that add trees + plant blocks

plants always risk having a part of them replaced
some plants have special conditions, so here's a sub-order for them:
- wide plants: trees, chorus plants, large mushrooms
- 1-block wide plants (grass-like plants, vines etc.)
- plants that check for light: mushrooms (so that they can generate underneath wide plants)
- plants that check for neighboring blocks: cactus

should generate after lakes - fixes MC-610 (1/2), MC-129153, MC-125858, MC-137452 (they're kind of duplicates), MC-197942
should generate after structures - fixes MC-140242
should generate after ores - fixes MC-610 (2/2), MC-181779 (2/2)
should generate after freezing - fixes MC-129888

Note: some of the bugs listed may not be reproducible anymore, but they're still open.

Some examples of this new order being used:

A lake is generated in a swamp, and then a hut is generated inside it. Seagrass and lily pads generate in the remaining space.
A monument / shipwreck / jungle temple generates, then biome vegetation generates on top of it (kelp, vines etc.) - they don't need to add their own vegetation.
A village generates paths, and plants can generate only in the remaining space.

Edit: vegetation already generated after structures.

Attachments

Simple Worldgen data-pack.zip

Comments

migrated 2021-04-15T16:01:59Z

[media][media]

anthony cicinelli 2021-04-23T16:12:08Z

Thank you for your report!
However, this issue is Invalid.

Please put only one bug report in each ticket. It is very difficult to keep track of bugs when they are not in their own tickets.
However, please review the Bug Tracker Guidelines before creating new reports. Be sure to search for an existing issue as it is likely to have already been reported.

Quick Links:
📓 Bug Tracker Guidelines – 💬 Community Support – 📧 Mojang Support
📓 Project Summary – ✍️ Feedback and Suggestions – 📖 Game Wiki

migrated 2021-04-23T16:34:36Z

This was intended as a collection issue for other bugs, because all of them can be fixed by simply changing the order in which features generate.

migrated 2021-04-23T16:54:52Z

In my opinion, structures should generate after ores to fix MC-170549.

migrated 2021-04-23T18:17:06Z

It seems that they already do, but there's a similar issue to MC-224006. Structures generate after ores, but afterwards they'll also generate their own. I'll need to investigate further.

migrated 2021-04-25T00:27:59Z

After more research, all of these problems seem to be related to chunk borders, and would need a more complex fix.

Please close this issue and MC-224006 for now.

migrated 2021-09-18T21:51:28Z

I also have this happen.

[media]

I was also using a simple worldgen data-pack that only modifies the ice spikes surface builder. -

[media]

I took the screenshot in the demo because I didn't have Minecraft bought in my own account.