mojira.dev
MC-116016

Advancement "adventure/trade" uses criteria named "shot_arrow"

The advancement minecraft:adventure/trade has a single criterion with a single trigger, trading with a villager. However, that criterion is called shot_arrow for some reason (probably because it was copy-pasted from minecraft:adventure/shoot_arrow, haha!)

Comments 3

This is actually a problem because I saw a YT vid that says that criteria names are shared across all advancements, so if that criteria "shot_arrow" were to be fulfilled in either "What a Deal!" or "minecraft:adventure/shoot_arrow", it would fulfil the criteria in the other advancement too, granting both advancements at the same time.

As a precaution, the devs should check the json files for the other advancements as well.

Not sure which video you watched, but that isn't true – each criteria is bundled with its advancement in uuid.json and are completed independently of one another.

I did check the other advancements and didn't see anything unusual.

I tested it for myself, and I was wrong, thankfully. Don't know why the guy in the vid said that.

tryashtar

Nathan Adams

Confirmed

advancement, trade

Minecraft 17w15a, Minecraft 17w16a, Minecraft 17w16b

Minecraft 17w17a

Retrieved