[MC-122536] "set_nbt" function in loot table does not merge NBT to item

The bug

"function": "set_nbt" in loot tables does nothing. Loot tables that worked in 1.12 don't show an error when loaded, but when the item is dropped the NBT data is not applied to it. This causes, for example, uncraftable potions in fishing and uncraftable arrows dropped by strays.

Code analysis

It appears that in 17w48a's bka class, the NBT data from the item is merged to the NBT data from the table, but is not merged back onto the item.

Linked issues

is duplicated by 4

MC-122606 Strays don't drop arrows of slowness Resolved

MC-122799 Potion from fishing is uncraftable potion Resolved

MC-122816 You can get an uncraftable potion from a fishing rod Resolved

MC-122850 set_nbt loot table function doesn't work Resolved

Attachments

horsebones_horsebones.json

Comments 4

user-f2760 2017-11-26T13:48:19Z

Side note: I can see 2 things wrong: ench's id and lvl are fully lowercase, no capitals, and set_count is not needed if it's 1.

Richard A. Hallett 2017-11-26T14:03:11Z

Thanks. I have corrected those. I wondered if perhaps the formatting had become stricter and that would fix it, but alas it still doesn't work.

David Urlich 2017-11-27T20:56:11Z

It also affects the default loot tables eg: Strays drop uncraftable arrows and fishing yields uncraftable potions

CreeperMagnet_ 2017-11-27T22:08:07Z

Can confirm. This bug is currently driving me up the wall. First it was MC-121379, and now this. Darn. I'm never gonna be able to get my function pack to 1.13.