mojira.dev
MC-124142

Wall banners use the same translation strings as standing banners

The bug

Wall banners use the same translation strings as their corresponding standing banners (block.minecraft.COLOR_banner), rather than just using their own. This bug was caused by the fix of MC-122579. Reverting that one's fix and adding the translations provided there would resolve this.

This will cause confusion as there's no distinction between the strings.

/give @s stick[can_break={predicates:[{blocks:"black_banner"}]}]
[media]

"Can Break Black Banner" cannot break black wall banners

/give @s stick[can_break={predicates:[{blocks:"black_wall_banner"}]}]
[media]

"Can Break Black Banner" breaks black wall banners

How to reproduce

  1. Use the below command for a demonstration

    /give @s stone[can_place_on={predicates:[{blocks:"red_wall_banner"},{blocks:"red_banner"}]}]
  2. Result:

    [media]

Linked issues

Attachments

Comments 16

Can confirm for 1.13.1-pre1.

If a moderator would like to make me the new reporter of this ticket I will keep it updated accordingly.

Done.

Affects 19w37a

@unknown - if you'd like, you can take this ticket from me. In the past I would've trusted myself to keep these tickets up to date, but my objectives have certainly changed since and I wouldn't mind now if a mod gave away my ticket to a user I could trust to keep it updated regularly. As far as I've seen, you've made some of the best efforts I've seen from users on the tracker and are to be congradulated 😃

I'd be completely fine with that, it's pretty simple to test anyway.

Affects 19w38b

6 more comments

Can confirm in 1.18.1.

Can confirm in 1.18.2.

Can confirm in 1.19 and 22w24a.

Can confirm in 1.19.2.

Confirmed for 1.19.3.

Connor, would you mind if I got made reporter again for this report (I was the original creator); I just found out about this issue affecting more blocks (see MC-258689 (only reason to keep them separate is because they actually have their translation strings in the language files)), so it wouldn't be that far apart to test this alongside it. I also see you haven't touched this report in over a year.

user-f2760

[Mod] turbo

(Unassigned)

Confirmed

Gameplay

Low

Text

CanDestroy, CanPlaceOn, banner, translation, translation-string, wall_banner

Minecraft 18w02a, Minecraft 18w07c, Minecraft 18w19b, Minecraft 1.13, Minecraft 18w30b, ..., 23w43b, 1.20.4, 1.21.1, 24w38a, 1.21.3

Retrieved