[MC-124444] Gamerule maxCommandChainLength allows 0 and negative integer values

The Bug

The gamerule maxCommandChainLength allows 0 and negative integer values, this makes no sense.

How to Reproduce

/gamerule maxCommandChainLength -1

Observed Behavior

The "maxCommandChainLength" gamerule allows 0 and negative integer values.

Expected Behavior

The "maxCommandChainLength" gamerule would not allow 0 and negative integer values.

Linked issues

relates to 2

MC-158451 maxCommandChainLength is set to 0 when loading pre-1.13 worlds Resolved

MC-259219 Game rule commandModificationBlockLimit can be set to a negative number Resolved

Attachments

MC-124444.mp4

Comments 15

Asteraoth 2018-08-18T14:51:54Z

Confirmed for 1.13.1-pre1

Asteraoth 2018-08-22T16:10:30Z

Confirmed for 1.13.1

Avoma 2020-12-14T16:50:06Z

Can confirm in 20w49a.

Avoma 2021-01-29T13:48:38Z

Can confirm in 21w03a.

Avoma 2021-02-08T15:35:04Z

Can confirm in 21w05b.

5 more comments

Avoma 2022-04-24T17:06:04Z

Can confirm in 1.18.2 and 22w16b.

Avoma 2022-06-19T13:16:17Z

Can confirm in 1.19 and 22w24a.

Avoma 2022-08-24T18:04:58Z

Can confirm in 1.19.2.

tryashtar 2022-09-02T07:19:33Z

In my opinion 0 should be allowed, and should effectively disable command blocks

marcono1234 2022-10-26T19:27:14Z

@@unknown, I think it might be better to have a separate gamerule (or even separate command which requires higher OP-level) for that. That would make it easier to discover and would avoid potentially undesired effects on other command execution logic (see also MC-124446, not sure if that still applies).