[MC-124446] No warning message when function is terminated because of maxCommandChainLength gamerule

The bug

When a function is terminated because the maxCommandChainLength gamerule value is reached no warning is printed to the log. For command blocks a warning is printed.

An error message is needed since terminating a function during its execution will likely cause undefined behavior.

How to reproduce

Download the attached file

[media]

and place it in the datapacks folder of your world
Make sure the value for maxCommandChainLength is at least 2
```
/gamerule maxCommandChainLength 2
```
Use the following command to verify that the function is working
```
/function custom:test
```
→ ✔ It runs two commands
Set the value for maxCommandChainLength to 1
```
/gamerule maxCommandChainLength 2
```
Run the function again
```
/function custom:test
```
→ ✔ It runs one command
Look at the log
→ ❌ No warning was logged

Attachments

MC-124446 datapack.zip

Comments 3

[Mod] redstonehelper 2018-01-22T22:29:35Z

Is this an issue on 1.12.2?

Nathan Adams 2018-01-23T13:01:32Z

As we suppress all error messages inside functions, this message would itself be suppressed. It would be inconsistent not to.

Brian McNamara 2018-01-23T14:14:21Z

This error is 'fatal' to command logic and should be treated specially; silently continuing from a broken program state with no hope of debuggability is a poor choice. This is a foolish "consistency".