[MC-131587] Deep frozen ocean biome does not generate with ice on the surface

Deep Frozen Ocean biome is not generating ice blocks on the surface, unlike shallow Frozen Ocean does. If the generation of an ice patch in a shallow Frozen Ocean attempts to enter the deep biome, it will be just cut, like if entered in warmer water.

Shots 5 and 4: same seed (pollinating sandboxes), same coordinates (0 128 0 0 90), but deep frozen ocean buffet in shot 5 and shallow frozen ocean in shot 4.

Shots 3, 2 and 1: an example in a default world. Shot 1 shows frozen ocean at left and deep frozen ocean at right. Shots 2 and 3 show the two sides of the biome border, at the same location.

The relevant code can be seen in this comment

Linked issues

Attachments

Comments 15

Néstor Ezquerra 2018-06-29T13:47:37Z

Still an issue in pre5.

pneuma 2018-07-30T22:48:14Z

I checked 1.13 decompiled source.
This biome initialized temp = 0.5

azb.class
........setTemperature(0.5F).setRainfall(0.5F).setWaterColor(3750089)..........

poweredbow 2019-09-10T08:29:45Z

This bug also making polar bears can't spawn on deep frozen ocean, because polar bears can only spawn on regular ice.

poweredbow 2019-10-31T09:59:59Z

Still in 19w44a.

poweredbow 2019-11-30T05:46:20Z

Please update affect version.

5 more comments

pneuma 2020-07-03T08:41:56Z

Still affected on 1.16.1

pneuma 2020-07-15T16:48:21Z

This issue has probably been resolved on 20w28a.

[media]

poweredbow 2020-08-24T06:42:37Z

No, not be fixed, on deep frozen ocean biomes, water only frozen on high Y level, not frozen at sea level.

[media]

pneuma 2020-08-24T11:10:30Z

Confirmed again.
This may be the intended specification, as it has been changed to set the temperature again.

snapshot 20w28a

public FrozenOceanBiome() {
    super((new Biome.BiomeBuilder())
        .surfaceBuilder(SurfaceBuilders.FROZEN_OCEAN)
        .precipitation(Biome.Precipitation.SNOW)
        .biomeCategory(Biome.BiomeCategory.OCEAN)
        .depth(-1.0F)
        .scale(0.1F)
        .temperature(0.0F)
        .downfall(0.5F)
        .specialEffects((new BiomeSpecialEffects.Builder())
          .waterColor(3750089)
          .waterFogColor(329011)
          .fogColor(12638463)
          .ambientMoodSound(AmbientMoodSettings.LEGACY_CAVE_SETTINGS)
          .build())
        
        .parent(null));
    addStructureStart(StructureFeatures.OCEAN_RUIN_COLD);
    BiomeDefaultFeatures.addDefaultOverworldOceanStructures(this);
    addStructureStart(StructureFeatures.RUINED_PORTAL_OCEAN);

snapshot 20w29a

public static Biome frozenOceanBiome(boolean paramBoolean) {
    FrozenOceanBiome frozenOceanBiome = new FrozenOceanBiome((new Biome.BiomeBuilder()).surfaceBuilder(SurfaceBuilders.FROZEN_OCEAN).precipitation(paramBoolean ? Biome.Precipitation.RAIN : Biome.Precipitation.SNOW).biomeCategory(Biome.BiomeCategory.OCEAN).depth(paramBoolean ? -1.8F : -1.0F).scale(0.1F).temperature(/* ★ ADDED AGAIN ★ --> */ paramBoolean ? 0.5F : 0.0F).downfall(0.5F).specialEffects((new BiomeSpecialEffects.Builder()).waterColor(3750089).waterFogColor(329011).fogColor(12638463).ambientMoodSound(AmbientMoodSettings.LEGACY_CAVE_SETTINGS).build()).parent(null));
    frozenOceanBiome.addStructureStart(StructureFeatures.OCEAN_RUIN_COLD);
    if (paramBoolean)
      frozenOceanBiome.addStructureStart(StructureFeatures.OCEAN_MONUMENT); 
    BiomeDefaultFeatures.addDefaultOverworldOceanStructures(frozenOceanBiome);
    frozenOceanBiome.addStructureStart(StructureFeatures.RUINED_PORTAL_OCEAN);