mojira.dev
MC-15189

Cobblestone Wall With Blocks On Top Shows Black Light On Its North Side With Maximum Smooth Lighting

The cobblestone wall texture is black when linked to another wall that is either on the end or has a torch on it. It only occurs on one side of the wall.

Linked issues

Attachments

Comments

Tails

Confirmed with any kind of blocks on top, this issue only appears on maximum smooth lighting on the north side of the wall (south from player's perspective).

Platypus

I can't seem to reproduce anymore as of 13w26a.

Tails

Still seeing it on the north side of the wall.

Yoann Petremann

I've looked at the code and seen that the problem (and the solution) is a careless mistakes

//  package net.minecraft.src;
//  ...
//  public class RenderBlocks {
//    ...
//    public boolean renderBlockWithAmbientOcclusion(Block par1Block, int par2, int par3, int par4, float par5, float par6, float par7) {
//      ...
//      if (this.renderAllFaces || par1Block.shouldSideBeRendered(this.blockAccess, par2, par3, par4 - 1, 2)) {
//        ...
          /* START OF OLD CODE *
          var9 = (float)((double)var22 * this.renderMaxY * (1.0D - this.renderMinX) + (double)var23 * this.renderMinY * this.renderMinX + (double)var24 * (1.0D - this.renderMaxY) * this.renderMinX + (double)var25 * (1.0D - this.renderMaxY) * (1.0D - this.renderMinX));
          * END OF OLD CODE */
          /* START OF NEW CODE *
          var9 = (float)((double)var22 * this.renderMaxY * (1.0D - this.renderMinX) + (double)var23 * this.renderMaxY * this.renderMinX + (double)var24 * (1.0D - this.renderMaxY) * this.renderMinX + (double)var25 * (1.0D - this.renderMaxY) * (1.0D - this.renderMinX));
          /* END OF NEW CODE */
          var10 = (float)((double)var22 * this.renderMaxY * (1.0D - this.renderMaxX) + (double)var23 * this.renderMaxY * this.renderMaxX + (double)var24 * (1.0D - this.renderMaxY) * this.renderMaxX + (double)var25 * (1.0D - this.renderMaxY) * (1.0D - this.renderMaxX));
          var11 = (float)((double)var22 * this.renderMinY * (1.0D - this.renderMaxX) + (double)var23 * this.renderMinY * this.renderMaxX + (double)var24 * (1.0D - this.renderMinY) * this.renderMaxX + (double)var25 * (1.0D - this.renderMinY) * (1.0D - this.renderMaxX));
          var12 = (float)((double)var22 * this.renderMinY * (1.0D - this.renderMinX) + (double)var23 * this.renderMinY * this.renderMinX + (double)var24 * (1.0D - this.renderMinY) * this.renderMinX + (double)var25 * (1.0D - this.renderMinY) * (1.0D - this.renderMinX));
//        ...
//      }
//      ...
//    }
//    ...
//  }

If you look at var10, var11 and var12 lines, each line uses this.renderMaxY or this.renderMinY, not both, same for this.renderMaxX or this.renderMinX.
the var9 line uses three this.renderMaxY and one this.renderMinY, I've tried to change that to use only this.renderMaxY on that line, and it solved the problem.

This thing with MC-190 solve the corner stair problem.

Concern 1.6.2 !

Yoann Petremann

Concern 13w37b !!!

Yoann Petremann

Affect 13w38a !

Yoann Petremann

This is the same bug for stairs.

Yoann Petremann

Affect 13w38c !

Yoann Petremann

Confirmed for 13w39a !

Yoann Petremann

Confirmed in 13w39b !

Yoann Petremann

Confirmed in 13w41a !

crazyman

Confirmed in 13w41b !

Yoann Petremann

bkw.class is a bugfix modification for Minecraft 13w42b for MC-15189 and MC-190

Please make a custom 13w42b version and install that file in the jar file

Yoann Petremann

Concern 13w43a !

Yoann Petremann

Concern 1.7.1 !

Erik Broes

Totally fixed!

Platypus

Erik Broes

Confirmed

cobble, light, stone, wall

Snapshot 13w18c, Snapshot 13w19a, Snapshot 13w21a, Snapshot 13w21b, Snapshot 13w22a, ..., Minecraft 1.6.2, Minecraft 1.6.4, Minecraft 13w42a, Minecraft 13w42b, Minecraft 13w43a

Minecraft 1.7.2

Retrieved