[MC-165510] Water and lava can't be placed on redstone ore

The bug

Right-clicking a redstone ore with a water/lava/fish bucket activates the redstone ore, but does not place the water or lava.

Code Analysis

Code analysis provided by @unknown

Currently the interaction on redstone ore is always a success. We can fix this by adding a check if the redstone ore is lit and if it is lit then fail the interaction

Current Code

net/minecraft/world/level/block/RedStoneOreBlock.java

public InteractionResult use(BlockState p_55472_, Level p_55473_, BlockPos p_55474_, Player p_55475_, InteractionHand p_55476_, BlockHitResult p_55477_) {
         if (p_55473_.isClientSide) {
            spawnParticles(p_55473_, p_55474_);
         } else {
            interact(p_55472_, p_55473_, p_55474_);
         }

      ItemStack itemstack = p_55475_.getItemInHand(p_55476_);
      return itemstack.getItem() instanceof BlockItem && (new BlockPlaceContext(p_55475_, p_55476_, itemstack, p_55477_)).canPlace() ? InteractionResult.PASS : InteractionResult.SUCCESS;
   }

Fixed Code

net/minecraft/world/level/block/RedStoneOreBlock.java

public InteractionResult use(BlockState p_55472_, Level p_55473_, BlockPos p_55474_, Player p_55475_, InteractionHand p_55476_, BlockHitResult p_55477_) {
       //Checking if its already lit then failing the result if it is lit fixes MC-165510 & MC-195094
      if(!p_55472_.getValue(LIT)) {
         if (p_55473_.isClientSide) {
            spawnParticles(p_55473_, p_55474_);
         } else {
            interact(p_55472_, p_55473_, p_55474_);
         }
      }
      else
      {
         return InteractionResult.FAIL;
      }

      ItemStack itemstack = p_55475_.getItemInHand(p_55476_);
      return itemstack.getItem() instanceof BlockItem && (new BlockPlaceContext(p_55475_, p_55476_, itemstack, p_55477_)).canPlace() ? InteractionResult.PASS : InteractionResult.SUCCESS;
   }

Linked issues

is duplicated by 11

MC-168090 Unable to place water on redstone ore Resolved

MC-171905 Clicking on Redstone Ore blocks interactions Resolved

MC-173415 Unable to use held item right click features while aiming at Redstone Ore Resolved

MC-182889 Water bucket on Redstone ore Resolved

MC-183101 seau d'eau sur un minerais de redstone Resolved

6 more links

relates to 1

MC-163921 Placing a block while looking at redstone ore plays no sound Resolved

Attachments

Без названия (19).mp4

Comments 46

[MOD] Greymagic27 2019-11-13T18:57:11Z

Can confirm. It happens to me also

SPGoding 2019-11-26T04:08:17Z

Confirmed for 1.15-pre2.

Mike Dedmon 2019-11-27T20:14:05Z

Confirmed for me too - 1.15-pre1 & pre2

Henry Harris 2019-12-07T15:34:57Z

Confirmed 19w42a, 19w44a, 19w45b

SPGoding 2019-12-07T15:40:34Z

@unknown, please don't comment for confirming outdated versions. Usually, only the latest release and the latest snapshot/pre-release can be added to Affected Versions.

36 more comments

C_moneySmith 2019-12-12T20:03:24Z

This effects release 1.15, as well. Additionally, it is not just limited to water. Lava bucket emptying, attempting to throw a trident or shoot a bow, consume anything (food or potion) also do not work unless sneaking. Basically any right-click interaction, other than placing a block, does not work.

Eric Rowley 2020-01-14T16:15:02Z

I can shoot a block of redstone ore or eat while looking at it if I am outside melee range, 5 blocks.

Tested in 1.15.1

–

I guess that's only to be expected, since the redstone ore can't be interacted with from more than 5 blocks away it won't interfere with the right click action.

[Mod] violine1101 2020-01-14T16:17:48Z

@unknown, that's a different issue. Please create a new ticket for that, if we don't have one already.

Eric Rowley 2020-01-14T20:37:29Z

No, I'm commenting on this issue, C_moneySmith pointed out that the issue affects a lot more than water buckets and I'm pointing out that the issue only occurs within 5 blocks of the redstone ore. (Water buckets can't be placed from more than 5 blocks away but water can be picked up even if the redstone is more than 5 blocks away as long as the water is closer.)

Aaron Perzan 2020-01-25T19:17:46Z

I have confirmed that this happens in 1.15.2 only if I am not sneaking. When sneak mode is activated, I can place the water on the redstone ore.

Ian Adams 2020-01-25T23:01:40Z

You can crouch to place it. It seems like the "make particles appear hehe" from right clicking is overriding actions used on the ore, just like how trying to place a block on a sign doesn't work.

anthony cicinelli 2020-03-11T04:21:54Z

This also affects Lava Buckets and Fish Buckets

C_moneySmith 2020-03-25T18:12:50Z

Confirmed for 20w13a

M G 2020-03-26T19:35:29Z

This also prevents eating and placing torches and redstone from your off hand.

Jayceebee 2020-04-17T09:15:46Z

20w16a

Hypermoron 2020-05-06T04:07:50Z

Confirmed for 20w18a

MMK21 2020-05-20T13:19:42Z

20w21a

C_moneySmith 2020-06-10T19:49:30Z

Confirmed for 1.16 pre-release 3

Conem 2020-06-10T19:51:18Z

@unknown: 1.16-pre3 is already marked as affected.

C_moneySmith 2020-06-16T18:33:22Z

Confirmed for 1.16 pre-release 7

C_moneySmith 2020-06-23T16:35:47Z

Confirmed for release 1.16

Z 2020-06-23T20:31:13Z

This might be intended/wanted behaviour. You can place the bucket while shifting. Much like how chests work, the water won't place itself on the chest unless you are shifting.

bluecrab2 2020-06-26T15:05:05Z

Confirmed in 1.16.1

pulpetti 2020-07-15T16:05:17Z

In 20w29a (Redstone should pop off and not just stay there until water reaches it.)

C_moneySmith 2020-07-29T17:27:16Z

Confirmed for 1.16.2 Pre-Release 1

Alex B 2020-07-29T17:48:24Z

Works as intended (watch the video)

C_moneySmith 2020-07-29T21:06:47Z

@unknown, that isn't working as intended. In all previous versions of Minecraft prior to 1.15 (I just tested myself in 1.14.4), you could still cause the redstone ore to light up while also completing your preferred interaction (water bucket, food consumption, bow draw). This bug prevents that from happening. It hurts no one to revert it to the old, proper functionality since this can lead to issues with caving, among other things.

anthony cicinelli 2020-09-29T04:48:25Z

It also affects Fish Buckets