[MC-179072] Creepers do not defuse when switching from Survival to Creative/Spectator

The bug

So whenever I go into creative mode and there is a creeper nearby it explodes. I was just testing an automated music disc farm, and when I went back into creative mode to get my stuff the creepers that weren't killed exploded for some reason. I am very confused right now..... ._.

Code analysis

Code analyses can be found in this comment by @unknown and this comment by @unknown.

Linked issues

is duplicated by 2

MC-202622 When using the Game mode Switcher when a Creeper or Skelton the mob still attacks the player even though they are in Creative Resolved

MC-263150 Creepers will still explode if you switch to creative mode Resolved

Attachments

Minecraft 1.15.2 - Singleplayer 4_16_2020 4_37_37 PM.png

Minecraft 1.15.2 - Singleplayer 4_16_2020 4_38_05 PM.png

Comments 7

Finnegan O'Donnell 2020-04-16T20:49:31Z

They were ignited, and continued to try to explode you

user-189af 2020-08-22T20:29:22Z

I died in creative mode for some reason, but it only happened once though.

Mateus Pereira Milbradt 2020-08-22T21:48:05Z

thcrafter06 And I died in spectator mode after switching from survival to spectator mode right when I falled from too high in Survival

Avoma 2021-02-01T16:24:22Z

Can confirm in 21w03a.

Avoma 2021-06-13T16:54:44Z

Can confirm in 1.17.

isXander 2022-04-08T08:27:48Z

Can confirm on 1.18.2

Code analysis

Based on 1.18.2 yarn mappings

CreeperIgniteGoal

@Override
public void tick() {
    if (this.target == null) { 
        this.creeper.setFuseSpeed(-1);
    } else if (this.creeper.squaredDistanceTo(this.target) > 49.0) {
        this.creeper.setFuseSpeed(-1);
    } else if (!this.creeper.getVisibilityCache().canSee(this.target)) {
        this.creeper.setFuseSpeed(-1);
    } else {
        this.creeper.setFuseSpeed(-1);
    }

This function does not check if the target can take damage.

BillyGalbreath 2022-09-06T18:42:14Z

This can be easily fixed by adding a `canContinueToUse()` override to `SwellGoal` pathfinder goal.

Using mojang's 1.19.2 mappings.

@Override
public boolean canContinueToUse() {
    return !EntitySelector.NO_CREATIVE_OR_SPECTATOR.test(this.creeper.getTarget()) && canUse();
}