[MC-190122] Game log for world load/reload is incomplete/inaccurate

Just loaded up a snapshot world with no datapacks, and the game log is definitely inaccurate. When I use /reload, it tells me:

15:28:39.432 Reloading ResourceManager: Default
15:28:39.978 Loaded 7 recipes
15:28:40.076 Loaded 927 advancements
15:28:40.383 Loaded 71 advancements

There's 927 advancements in the default datapack, so that part's right, but there's way more than 7 recipes in the default datapack. The log doesn't mention loot tables, structures, or tags at all, and there's somehow an additional 71 'advancements'?

Loading up a world I had on hand with datapacks that include additional recipes, predicates, loot tables, structures, functions and tags, the recipes from that datapack are not included in the count (it still claims only 7 recipes are loaded). The functions and predicates from the datapacks are not listed at all, and while the first advancements number remains accurate, the second...I don't know what that's counting at all, because the number changes, but not by the same number as anything contained in the datapacks.

Comments 4

Alex O'Neill 2020-11-23T18:11:22Z

The recipe count is actually vanilla's error message displaying the number of recipe types, not the total number of recipes. This change happened somewhere around 1.14 I believe, once recipe types were introduced. It can be fixed very simply. In 1.16.4, using official mappings:

// In RecipeManager.apply(), at the last line, instead of 
// LOGGER.info("Loaded {} recipes", map.size());
// It should read:
LOGGER.info("Loaded {} recipes", this.recipes.values().stream().mapToInt(Map::size).sum());

user-f2760 2021-12-03T09:23:24Z

Still in 1.18; it also doesn't display loaded biomes, dimensions, and other worldgen things.
I don't have the "duplicate" Loaded X advancements though.

user-f2760 2021-12-03T09:26:35Z

If you (Callum) aren't opposed, I'd like to be made the reporter of this, so I could keep the report updated and make the description a bit easier to grasp when skimming over the report (I had to actually search for the "affected" files that don't show in your report, rather than easily find that info in the blink of an eye)

user-f2760 2022-06-07T19:30:30Z

Confirmed for 1.19.