Soul Speed effect remains after switching to spectator mode

Hi there!

I can confirm in release 1.16.1 and snapshot 20w30a.

Can confirm for 20w51a.

Can confirm in 21w03a.

Can confirm in 21w06a. Feel free to use the following command to make reproducing this much easier:

/give @s minecraft:netherite_boots{Enchantments:[{id:"soul_speed",lvl:3}]}

Can confirm in 21w08b. Video attached.

Can confirm in 1.18.2.

Code analysis

Tested in 1.18.2 with yarn mappings

net.minecraft.entity.LivingEntity

protected boolean shouldRemoveSoulSpeedBoost(BlockState landingState) {
   return !landingState.isAir() || this.isFallFlying();
}

This piece of code is responsible from removing the speed boost from an entity.

Suggested Fix

@Override
protected boolean shouldRemoveSoulSpeedBoost(BlockState landingState) {
   return super.shouldRemoveSoulSpeedBoost(landingState) || this.isSpectator();
}

Simply override the check in PlayerEntity check if the player is in spectator mode. If so, return true!

Can confirm in 1.19.2.

Can confirm in 1.19.3.

This looks to be fixed in 24w18a based off my inability to reproduce the issue anymore, despite being able to successfully in 1.20.6: