mojira.dev
MC-216964

Noise caves still generate with noise_caves_enabled set to false

The bug

When creating custom world using a datapack, there is an option in the noise settings called noise_caves_enabled. When this option is set to false, the noise caves still generate. 

The expected behaviour is for the noise caves to no longer generate.

I have added a datapack to this issue with the settings I used and I have disabled the carvers in the biome files in this datapack.

How to reproduce

  1. Download the supplied datapack

  2. Import it into new world

  3. Generate the world

  4. Go into spectator mode and look at the caves, the noise caves still generate

Attachments

Comments 4

I have found a a way to fix this in the datapack itself. When I replace the line "structures": {} in the noise setting file (data\minecraft\worldgen\noise_settings\overworld.json), with this:
___________________________
"structures":

{     "stronghold":
{ "distance": 32, "spread": 3, "count": 0 },
    "structures": {}
},
__________________________

The noise caves are then not generated anymore. I suspect the code reading the json file breaks when the "stronghold" tag is not present.

I hope this helps debugging this further.

Without stronghold the dimension is invalid, and will indeed "break" the JSON but this is WAI iirc

Invalid/WAI - the given noise_settings/overworld.json file is not functional, so the game uses the default settings. If you use a proper file it will work.

Invalid data is not loaded by the game.

Lennart Jensen

(Unassigned)

Confirmed

Important

Custom Worlds, Data Packs

world-generation

21w08a, 21w08b

Retrieved