[MC-229882] Predicate still passes for certain stacks even after dropping them

The bug

If you drop an item, the predicate will still say you are holding that item, even if there is nothing in your hand. Opening your inventory and clicking on the slot where the item used to be will update it and the using the predicate will result in the correct outcome.

Did not happen in 1.16.5

How to reproduce

Create a predicate as follows:

{
  "condition": "minecraft:entity_properties",
  "entity": "this",
  "predicate": {
    "equipment": {
      "mainhand": {
        "nbt": "{Cap:1b}"
      }
    }
  }
}

Give yourself a shield with the tag Cap:1b,
```
/give @s shield{Cap:1b}
```
Drop the item
Test the predicate
```
execute if predicate ...
```
❌ It will result in "Test Passed"
Go into your inventory and click on your empty selected item slot, then testing the predicate again will result in "Test Failed"

Linked issues

is duplicated by 2

MC-232744 The predicate entity_properties.equipment ignores "items" if one drop the item on the slot Resolved

MC-267816 Use predicate to check NBT of the item. Throw the item but the result of predicate remain no change. Resolved

relates to 1

MC-229983 /clear command doesn't clear certain stacks after dropping items from them Resolved

Attachments

2021-06-21 18-07-57.mp4

Comments 9

tryashtar 2021-06-22T02:29:53Z

See MC-226525

tryashtar 2021-07-08T21:32:56Z

Hi I'm back. Sorry, I misunderstood the issue. As in MC-226525 you do indeed need to update your item key to items, but the problem with dropping sounds more similar to MC-229983. Since I was told this is still an issue, I'll reopen it now and change the title. Sorry about that.

mrpingouin1 2021-07-11T23:22:55Z

It's still an issue in 1.17.1. The mentioned bug don't seem to be exactly related.
Adding items does fix the issue, but you might want to test regardless of the exact item id, and adding the following part still does cause the same issue :

"items": [
          "minecraft:golden_sword","minecraft:air"
        ]

CreeperMagnet_ 2022-01-19T00:30:44Z

Is there any reasoning behind why this is marked as working as intended? This bug is still present as of 1.18.1, and I don't see any developer comment other than Adrian marking it.

user-f2760 2022-11-10T16:43:11Z

I'd like to request a review for this. The predicate still passing while the item no longer is in the inventory is nonsensical, and the expected behavior would be to only pass if it exists. The fact that clicking on the slot or relogging changes the result makes this look like a desync too.

serpico84 2023-05-22T09:29:50Z

I'm sorry but why has this been marked as resolved and "works as intended", when it clearly isn't? A predicate that checks for an item in the mainhand with a specific NBT tag can not be considered "working as intended" if it passes when there's no item at all in the player hand.

I'm asking for this to be reopened.

rorybd 2023-12-05T18:40:23Z

Can confirm in 1.20.3

Triton365 2024-10-06T15:18:55Z

Does not occur in 1.21.1. It seems it was fixed somewhere between 1.20.4 and 1.21.1

Also here are the commands for recent versions.

/give @s shield[custom_data={Cap:1b}]
/execute if predicate {condition:entity_properties,entity:this,predicate:{equipment:{mainhand:{predicates:{custom_data:{Cap:1b}}}}}}

Misode 2024-10-07T23:12:25Z

It makes sense that this would've been fixed in 1.20.5 when they introduced item components