[MC-238920] Soul campfire recipe unlocks when obtaining a stick

The advancement that unlocks the soul campfire recipe can be achieved by obtaining either soul sand, or a stick.

Since sticks are one of the very first items a player obtains, this is one of the very first recipes to be unlocked. It's a bit unusual, since soul campfires are an otherwordly-looking item that aren't truly obtainable until entering the nether.

The other two soul items are only unlocked when obtaining a nether ingredient: torches when obtaining soul sand/soil, and soul lanterns when obtaining soul torches. So when you gather soul sand for the first time, the game will inform you that you can now craft soul torches, but won't inform you that you can now craft soul campfires, since you already unlocked that recipe ages ago.

I think the intention was to unlock this recipe after both sticks and soul sand have been obtained, and likewise for stick and coal for the regular campfire.

Attachments

Comments 6

Avoma 2021-12-09T18:37:32Z

I can confirm this behavior in 1.18.

Here's a code analysis of this issue. The following is based on a decompiled version of Minecraft 1.18 using MCP-Reborn. Please note that I'm quite tentative about this analysis, although I'm persuaded to believe that this is likely the cause of the problem. 🙂

Code Analysis (tentative):

net.minecraft.data.recipes.RecipeProvider.java

public class RecipeProvider implements DataProvider {
   ...
   private static void buildCraftingRecipes(Consumer<FinishedRecipe> $$0) {
      BlockFamilies.getAllFamilies().filter(BlockFamily::shouldGenerateRecipe).forEach(($$1) -> {
         generateRecipes($$0, $$1);
      });
      ...
      ShapedRecipeBuilder.shaped(Blocks.SOUL_CAMPFIRE).define('L', ItemTags.LOGS).define('S', Items.STICK).define('#', ItemTags.SOUL_FIRE_BASE_BLOCKS).pattern(" S ").pattern("S#S").pattern("LLL").unlockedBy("has_stick", has(Items.STICK)).unlockedBy("has_soul_sand", has(ItemTags.SOUL_FIRE_BASE_BLOCKS)).save($$0);

If we look at the above class, we can see that upon obtaining a stick, you are awarded the soul campfire recipe. This is evident through the following line of code:

.unlockedBy("has_stick", has(Items.STICK))

Potential Fix:

Simply removing .unlockedBy("has_stick", has(Items.STICK)) within this particular piece of code should prevent the soul campfire recipe from being unlocked upon obtaining a stick and would resolve this problem. The correct line of code within its class should look something like the following:

net.minecraft.data.recipes.RecipeProvider.java

public class RecipeProvider implements DataProvider {
   ...
   private static void buildCraftingRecipes(Consumer<FinishedRecipe> $$0) {
      BlockFamilies.getAllFamilies().filter(BlockFamily::shouldGenerateRecipe).forEach(($$1) -> {
         generateRecipes($$0, $$1);
      });
      ...
      ShapedRecipeBuilder.shaped(Blocks.SOUL_CAMPFIRE).define('L', ItemTags.LOGS).define('S', Items.STICK).define('#', ItemTags.SOUL_FIRE_BASE_BLOCKS).pattern(" S ").pattern("S#S").pattern("LLL").unlockedBy("has_soul_sand", has(ItemTags.SOUL_FIRE_BASE_BLOCKS)).save($$0);

Avoma 2021-12-17T10:22:32Z

Can confirm in 1.18.1.

Avoma 2022-04-13T15:23:33Z

Can confirm in 1.18.2.

Avoma 2022-06-08T18:16:22Z

Can confirm in 1.19.

Avoma 2023-02-15T17:06:43Z

This issue has been fixed in 23w07a.

ampolive 2023-02-15T17:11:45Z

Can confirm fixed in 23w07a.