[MC-242543] Suffocation always uses the entity head center position for predicate and collision box

This causes suffocation in open shulker boxes that are not in the center of the head to occur and suffocation in shulker boxes to not occur when the center of the head is inside an open shulker box

Attachments

shulker_suffocation.nbt

Comments

migrated 2021-11-22T20:18:53Z

[media][media][media]

migrated 2021-11-23T15:50:16Z

pls fix mojang

Moesh 2021-11-24T09:39:11Z

I was unable to reproduce this in 1.18-pre7 or 1.17. Could you provide a screenshot of a working repro case? With villagers and players, both were squished down to swimming or pushed out, but no suffocating happened.

Let me know and I'll check it out again. Thanks!

2No2Name 2021-11-27T05:40:23Z

Place a mob inside a boat, so that the head of the mob is inside two blocks. Set the blocks at the head to shulker boxes using /setblock. Observe the behavior when opening the different boxes

tryashtar 2021-12-07T22:19:14Z

I attached a structure file that may help. Try loading it and running these tests:

Observed results:

Both boxes closed: creeper suffocates ✔

Purple box opened: creeper suffocates ✔

Yellow box opened: creeper doesn't suffocate ❌

As far as I understand, the last case is considered to be this bug because the creeper is still inside of the purple box, and therefore should suffocate. If the yellow box is broken, the creeper correctly suffocates.

tryashtar 2021-12-13T21:59:20Z

Also this is new to 1.18, presumably caused by the changes to suffocation in 21w37a