The bug
Placing a structure or a feature doesn't appear to cause block updates or light updates, leaving water without a source in the world.
[media][media][media][media][media][media][media]Code analysis
Code analysis by @unknown can be found in this comment.
Linked issues
Attachments
Comments 7
It seems like the method used in the features that are incorrectly placed provide an incorrect argument: the flags.
With Fabric's mappings I was able to indentify that there was a "setBlockState" method within the "Feature" class that should be used for all features, but is not. They call for the more generic "setBlockState" method, in the "ModifiableWorld" class with the flags argument set to 3, which means "notify the neighbor blocks, listeners and the client when the block is placed". You can also notify only the listeners and the client by using the value 2. However, some features call for the generic "setBlockState" method with 4 as the argument, which tells the client to suppress the render pass on clients.
Feature classes that do not use the "notify listener" include:
ForestRockFeature
FossilFeature
HugeFungusFeature
BlockPileFeature
Request me to be the reporter of the issue, not only does the original reporter (Brain180) is inactive but also that reporter it's literally me.
Can confirm in 22w14a.
[media][media]